Preact-cli: eslint also lints build directory

[robinvdvleuten]

Do you want to request a feature or report a bug?

bug

What is the current behavior?

When I run npm test, it runs eslint which lints the build directory by default.

If the current behavior is a bug, please provide the steps to reproduce.

npm test

What is the expected behavior?

I expect that only my source files are linted

[developit]

Hmm - looks like it is bound only to src: https://github.com/developit/preact-cli/blob/80a77acc3df6ec7acbf4b11c7e13dd5ee2e64a6e/src/lib/setup.js#L53

Maybe an older scaffolded project?

Might be good to have it scaffold an eslintrc.

[robinvdvleuten]

@developit ah my bad! I am using version v1.4.1 which doesn't have this change. Maybe it would be nice to automatically let the CLI generate an eslint config.

[lukeed]

@robinvdvleuten That _is_ from v1.4.1 🤔

[developit]

I wish it was possible to define ignored/included directories in eslintConfig in the package.json :(

[reznord]

It is possible and I did in one of the PRs. But since we thought of going with templates, I closed that issue.

[reznord]

@developit, added in the templates

[reznord]

@robinvdvleuten you can add "eslintIgnore": ["build/*"] to your package.json, that will ignore the build folder while linting.

[robinvdvleuten]

@reznord I did by adding an .eslintignore file, thanks for all the help!