Ppsspp: Google Play crash report mystery thread 1.7

Created on 27 Oct 2018  路  29Comments  路  Source: hrydgard/ppsspp

It's time for the crash report thread again, preparing for 1.7.1!

Starting off with a golden oldie, this one is not actually new but deserves to be looked at:
(one phone that it happens on is Samsung Galaxy Grand Prime Pro (j2y18lte), Android 7.1)

  #00  pc 000000000035b4a0  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN20DepalShaderCacheGLESC1EPN4Draw11DrawContextE+51)
  #01  pc 000000000035d2c3  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN8GPU_GLESC1EP15GraphicsContextPN4Draw11DrawContextE+62)
  #02  pc 00000000003c5b95  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z8GPU_InitP15GraphicsContextPN4Draw11DrawContextE+60)
  #03  pc 00000000003502c1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z14PSP_InitUpdatePNSt6__ndk112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE+216)
  #04  pc 00000000004275cd  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN9EmuScreen8bootGameERKNSt6__ndk112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE+44)
  #05  pc 000000000042b36f  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN9EmuScreen6updateEv+50)
  #06  pc 00000000004baee9  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN13ScreenManager6updateEv+40)
  #07  pc 0000000000425c47  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z12NativeUpdatev+146)
  #08  pc 00000000004203a3  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z20UpdateRunLoopAndroidP7_JNIEnv+10)
  #09  pc 00000000004216f5  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so
  #10  pc 00000000002b7325  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+24)
  #11  pc 0000000000047d03  /system/lib/libc.so (_ZL15__pthread_startPv+22)
  #12  pc 000000000001a00d  /system/lib/libc.so (__start_thread+6)
picture hrydgard
😄1 👍1

Most helpful comment

Turns out I was wrong in that the fix will make 1.7.1 :) I don't see any other really surprising big crashers, so I'm going to release 1.7.1 tomorrow and start at a pretty high rollout, before we go to 100%.

picture hrydgard on 31 Oct 2018
❤1 🎉1 👍1

All 29 comments

screenshot_2018-10-27-21-22-48
screenshot_2018-10-27-21-23-04

My ppsspp version still 1.6.3 :(

Gamemulatorer picture Gamemulatorer on 27 Oct 2018

That is expected, as I wrote on the website it's a rollout over the week so I can catch bad bugs before everyone gets them. Patience.

hrydgard picture hrydgard on 27 Oct 2018
👍2

Do we know if that crash is a segfault or what?

I guess it must mean draw is null if it's a segfault. Maybe stop during startup issue? I can't really see how it gets there null...

-[Unknown]

unknownbrackets picture unknownbrackets on 27 Oct 2018

@hrydgard Opps... I forgot sorry 馃槄

Gamemulatorer picture Gamemulatorer on 27 Oct 2018

I suppose the segfault means that while EmuScreen was looping and called PSP_InitUpdate(), another thread (or an event before bootGame was called?) deleted draw.

Which basically means ShutdownFromRenderThread was called, either on a separate thread, or in a way that failed to prevent EmuScreen::update() from being called. But we call EmuThreadJoin() before each version of that, even on display reinit.

It would've crashed earlier if the draw alloc failed...

-[Unknown]

unknownbrackets picture unknownbrackets on 27 Oct 2018

I'm not sure that first one was even real (filtering is being weird) but this one is:

  #00  pc 000000000038a1d4  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN22FramebufferManagerGLES17DrawActiveTextureEffffffffffii+631)
  #01  pc 000000000038b81b  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN22FramebufferManagerGLES15BlitFramebufferEP18VirtualFramebufferiiS1_iiiii+1226)
  #02  pc 00000000003b9fb9  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon26DownloadFramebufferForClutEjj+392)
  #03  pc 00000000003db37b  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN18TextureCacheCommon8LoadClutEjj+498)
  #04  pc 00000000003eff79  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN9GPUCommon15ReapplyGfxStateEv+284)
  #05  pc 00000000003ee537  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN9GPUCommon14BeginHostFrameEv+10)
  #06  pc 0000000000383c3d  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN8GPU_GLES14BeginHostFrameEv+6)
  #07  pc 000000000044c8c9  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN9EmuScreen6renderEv+216)
  #08  pc 00000000004deff1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN13ScreenManager6renderEv+84)
  #09  pc 0000000000445a27  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z12NativeRenderP15GraphicsContext+810)
  #10  pc 00000000004409cf  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z20UpdateRunLoopAndroidP7_JNIEnv+22)

And this:

#01 pc 00000000004d23b5 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN13GLQueueRunner18CopyReadbackBufferEiiN4Draw10DataFormatES1_iPh+48) #02 pc 00000000004ceed1 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN15GLRenderManager27CopyFramebufferToMemorySyncEP14GLRFramebufferiiiiiN4Draw10DataFormatEPhi+180) #03 pc 00000000004cac21 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw13OpenGLContext27CopyFramebufferToMemorySyncEPNS_11FramebufferEiiiiiNS_10DataFormatEPvi+92) #04 pc 00000000003b9def /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon20PackFramebufferSync_EP18VirtualFramebufferiiii+166) #05 pc 00000000003b4f93 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon23ReadFramebufferToMemoryEP18VirtualFramebufferbiiii+146) #06 pc 00000000003b6221 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon19CopyDisplayToOutputEv+624) #07 pc 0000000000383dad /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN8GPU_GLES19CopyDisplayToOutputEv+52) #08 pc 00000000002ce4ff /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z13__DisplayFlipi+1582) #09 pc 00000000002cd21f /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z14hleEnterVblankyi+366) #10 pc 00000000002674cf /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN10CoreTiming7AdvanceEv+366) #11 pc 000000000030c933 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z18__KernelReSchedulePKc+30)

hrydgard picture hrydgard on 28 Oct 2018

Hm. We seem to be missing a null check for FindDownloadTempBuffer, but that can't be it. For DrawActiveTexture to crash, I guess we ran out of push buffer or render_ became invalid? OOM?

-[Unknown]

unknownbrackets picture unknownbrackets on 28 Oct 2018

Yeah, OOM can probably explain a lot of the stranger ones...

hrydgard picture hrydgard on 28 Oct 2018

``` #00 pc 00000000004cb130 /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN4Draw13OpenGLContext22CreateGraphicsPipelineERKNS_12PipelineDescE+127)
#01 pc 00000000004452ff /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_Z18NativeInitGraphicsP15GraphicsContext+1086)
#02 pc 0000000000441c83 /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so
#03 pc 000000000026e489 /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+24)

#08 pc 0000000000a0f965 /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (__cxa_pure_virtual+8)
#09 pc 0000000000381029 /data/app/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN20DepalShaderCacheGLESC1EPN4Draw11DrawContextE+60)

Failure during creation?

#00 pc 00000000004c98de /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw16RefCountedObject7ReleaseEv+27)
#01 pc 00000000004cca01 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw14OpenGLPipelineD2Ev+52)
#02 pc 00000000004ccaad /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw14OpenGLPipelineD0Ev+4)
#03 pc 00000000004cb1d5 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw13OpenGLContext22CreateGraphicsPipelineERKNS_12PipelineDescE+292)
#04 pc 0000000000445311 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z18NativeInitGraphicsP15GraphicsContext+1104)
#05 pc 0000000000441c83 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so
#06 pc 000000000026e489 /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+24)

Hit an assert:

#03 pc 00000000005a84a8 /data/app/org.ppsspp.ppsspp-kjnPFXC4QqtPKDFqg4-Y0A==/lib/arm64/libppsspp_jni.so (_Z16AndroidAssertLogPKcS0_iS0_S0_z+164)
#04 pc 00000000004f1498 /data/app/org.ppsspp.ppsspp-kjnPFXC4QqtPKDFqg4-Y0A==/lib/arm64/libppsspp_jni.so (_ZN12DenseHashMapI9FShaderIDP20VulkanFragmentShaderLS2_0EE4GrowEi+516)
#05 pc 00000000004effec /data/app/org.ppsspp.ppsspp-kjnPFXC4QqtPKDFqg4-Y0A==/lib/arm64/libppsspp_jni.so (_ZN12DenseHashMapI9FShaderIDP20VulkanFragmentShaderLS2_0EE6InsertERKS0_S2_+72)
#06 pc 00000000004f0a54 /data/app/org.ppsspp.ppsspp-kjnPFXC4QqtPKDFqg4-Y0A==/lib/arm64/libppsspp_jni.so (_ZN19ShaderManagerVulkan9LoadCacheEP7__sFILE+488)
#07 pc 00000000004ea2d0 /data/app/org.ppsspp.ppsspp-kjnPFXC4QqtPKDFqg4-Y0A==/lib/arm64/libppsspp_jni.so (_ZN10GPU_Vulkan9LoadCacheENSt6__ndk112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE+160)
#08 pc 00000000004eb7d0 /data/app/org.ppsspp.ppsspp-kjnPFXC4QqtPKDFqg4-Y0A==/lib/arm64/libppsspp_jni.so
```

hrydgard picture hrydgard on 28 Oct 2018

Hm, that assert is concerning - _assert_msg_(SYSTEM, oldCount == count_, "DenseHashMap: count should not change in Grow()");. Could it mean threaded access to the densehashmap?

For the refcount one, I can't repro by forcing a compile/link failure, but we probably want a null check in render_->DeleteProgram(program_); - though I doubt that's the cause.

DepalShaderCacheGLES pure virtual - more signals that draw is being freed.

NativeInitGraphics crash - hmm. Maybe some related condition where g_draw became invalid?

-[Unknown]

unknownbrackets picture unknownbrackets on 28 Oct 2018

Okay, so I think the hash map thing is happening due to a DeviceLost() or similar while loading cache.

The simplest thing might be to wait for GPU_IsReady() in GPU_Shutdown(), although this might delay things...

-[Unknown]

unknownbrackets picture unknownbrackets on 30 Oct 2018

A crash during cache loading isn't really such a terrible case, no user data will be lost at least... Not gonna let this stop 1.7.1

hrydgard picture hrydgard on 30 Oct 2018
😄2 😕1 👎1 👍1

Turns out I was wrong in that the fix will make 1.7.1 :) I don't see any other really surprising big crashers, so I'm going to release 1.7.1 tomorrow and start at a pretty high rollout, before we go to 100%.

hrydgard picture hrydgard on 31 Oct 2018
❤1 🎉1 👍1

Sir @hrydgard v1.7.1 is the final version and officialy release tomorrow in PlayStore?
or there's still a minor update like v1.7.2?

p.s sorry for my bad english and asking too much and thank you for your hard work to make ppsspp a better emulator god bless and happy halloween

Gamemulatorer picture Gamemulatorer on 31 Oct 2018

Depends if we find more critical issues, but hopefully 1.7.1 will be the final official one in the 1.7 series.

hrydgard picture hrydgard on 31 Oct 2018
👍1

Found a graphics glitch
screenshot_2018-11-03-21-19-48
in Burnout Legend using v1.7.1 didn't happen this issue in v1.7.0

Gamemulatorer picture Gamemulatorer on 3 Nov 2018

That is wacky, but it has no business being in this thread. Please create a new issue report.

hrydgard picture hrydgard on 3 Nov 2018

Seems ok now in the latest build 1.7.1-28
Do I still need to submit issue?

Gamemulatorer picture Gamemulatorer on 3 Nov 2018

How are the Play crashes looking now? Should we close this?

-[Unknown]

unknownbrackets picture unknownbrackets on 19 Nov 2018

Well, it's not perfect but I don't think it's worse than before...

hrydgard picture hrydgard on 19 Nov 2018

Actually, this one is still happening, and I don't understand how:

backtrace:
  #00  pc 00000000000178c8  /system/lib/libc.so (__memcpy_base_aligned+172)
  #01  pc 00000000004d2b55  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN13GLQueueRunner18CopyReadbackBufferEiiN4Draw10DataFormatES1_iPh+48)
  #02  pc 00000000004cf625  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN15GLRenderManager27CopyFramebufferToMemorySyncEP14GLRFramebufferiiiiiN4Draw10DataFormatEPhi+216)
  #03  pc 00000000004cb351  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw13OpenGLContext27CopyFramebufferToMemorySyncEPNS_11FramebufferEiiiiiNS_10DataFormatEPvi+92)
  #04  pc 00000000003ba175  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon20PackFramebufferSync_EP18VirtualFramebufferiiii+428)
  #05  pc 00000000003b52a1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon23ReadFramebufferToMemoryEP18VirtualFramebufferbiiii+288)
  #06  pc 00000000003b64a1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon19CopyDisplayToOutputEv+624)
  #07  pc 0000000000383fad  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN8GPU_GLES19CopyDisplayToOutputEv+52)
  #08  pc 00000000002ce6ef  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z13__DisplayFlipi+1582)
  #09  pc 00000000002cd40f  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z14hleEnterVblankyi+366)
  #10  pc 000000000026764f  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN10CoreTiming7AdvanceEv+366)
  #11  pc 000000000030cb23  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z18__KernelReSchedulePKc+30)
  #12  pc 0000000000004420  <unknown>

Mainly on small/weak phones though, could be out of memory when it tries to alloc the temp buffer?

hrydgard picture hrydgard on 21 Nov 2018

Quietly pushed 1.7.4 to a subset on Play, and this thing is STILL happening. I don't get it.

  #00  pc 00000000000174b8  /system/lib/libc.so (memcpy+96)
  #01  pc 00000000004d2be5  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN13GLQueueRunner18CopyReadbackBufferEiiN4Draw10DataFormatES1_iPh+48)
  #02  pc 00000000004cf6a5  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN15GLRenderManager27CopyFramebufferToMemorySyncEP14GLRFramebufferiiiiiN4Draw10DataFormatEPhi+216)
  #03  pc 00000000004cb3d1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw13OpenGLContext27CopyFramebufferToMemorySyncEPNS_11FramebufferEiiiiiNS_10DataFormatEPvi+92)
  #04  pc 00000000003ba175  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon20PackFramebufferSync_EP18VirtualFramebufferiiii+428)
  #05  pc 00000000003b52a1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon23ReadFramebufferToMemoryEP18VirtualFramebufferbiiii+288)
  #06  pc 00000000003b64a1  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN24FramebufferManagerCommon19CopyDisplayToOutputEv+624)
  #07  pc 0000000000383fad  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN8GPU_GLES19CopyDisplayToOutputEv+52)
  #08  pc 00000000002ce6af  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z13__DisplayFlipi+1582)
  #09  pc 00000000002cd3cf  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z14hleEnterVblankyi+366)
  #10  pc 000000000026760f  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN10CoreTiming7AdvanceEv+366)
  #11  pc 000000000030cae3  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z18__KernelReSchedulePKc+30)
  #12  pc 00000000000748f0  <anonymous>
hrydgard picture hrydgard on 24 Nov 2018

My best guess is: what if the frame sync is off, and it never runs PerformReadback. We just assume readbackBuffer_ is allocated at that point.

I don't see how the destination can be wrong, or the stride, or the height. So that's my only idea left...

-[Unknown]

unknownbrackets picture unknownbrackets on 24 Nov 2018

Yup, that's got to be it. Checked in a fix for that too....

hrydgard picture hrydgard on 24 Nov 2018

Pretty weird one:

  #00  pc 000000000066444c  /data/app/org.ppsspp.ppsspp-oDgxNlw1GINOIpodaiGXRA==/lib/arm64/libppsspp_jni.so (Draw::OpenGLContext::CreateGraphicsPipeline(Draw::PipelineDesc const&)+204)
  #01  pc 00000000005ad368  /data/app/org.ppsspp.ppsspp-oDgxNlw1GINOIpodaiGXRA==/lib/arm64/libppsspp_jni.so (NativeInitGraphics(GraphicsContext*)+1260)
  #02  pc 00000000005a8a5c  /data/app/org.ppsspp.ppsspp-oDgxNlw1GINOIpodaiGXRA==/lib/arm64/libppsspp_jni.so
  #03  pc 00000000003483b8  /data/app/org.ppsspp.ppsspp-oDgxNlw1GINOIpodaiGXRA==/lib/arm64/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+44)
  #04  pc 0000000000067dc0  /system/lib64/libc.so (__pthread_start(void*)+36)
  #05  pc 000000000001ec58  /system/lib64/libc.so (__start_thread+68)
hrydgard picture hrydgard on 24 Nov 2018

But if the frame sync is so off that this happens, we have another serious bug somewhere..

hrydgard picture hrydgard on 24 Nov 2018

Perhaps it's just during shutdown?

Not sure about the pipeline, maybe an allocation failure...

-[Unknown]

unknownbrackets picture unknownbrackets on 24 Nov 2018

Ah yeah, could be. My checked-in workaround should be good enough if it is.

hrydgard picture hrydgard on 24 Nov 2018

I'm declaring this mostly done and closing. Until the 1.8 one...

hrydgard picture hrydgard on 7 Jan 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

oatmeal picture oatmeal  路  6Comments
hrydgard picture hrydgard  路  5Comments
marosis picture marosis  路  6Comments
fahadfoyjur picture fahadfoyjur  路  5Comments
SwiftBMan picture SwiftBMan  路  3Comments