Powertoys: [color picker] lost color history after switching Activation behavior

[JolyonJostar]

[martinchrzan]

@JolyonJostar Can you provide more info? Did the whole color history disappear or just a few colors? Can you reproduce it all the time?

[JolyonJostar]

@JolyonJostar Can you provide more info? Did the whole color history disappear or just a few colors? Can you reproduce it all the time?

OK, when i try to reproduce today,i found it not that simple
situation 1,if there are no so many color,for example,2 color in history
->switching mode between [color picker with editor enable] and [editor]
->using shortcut to call out color picker
->all color history disappear
situation 2,if there are already have many color,20 for example
->remove some color(20->15)
->switching mode between [color picker with editor enable] and [editor]
->using shortcut to call out color picker
->now the color history remain 20

i'm not sure if i describe clear enough, I can provide a screen record if needed

[htcfreek]

have found the repo steps.
Will post it later with a few other bugs.

[htcfreek]

I can repro the problem by doing the following steps:

1. Open settings and configure the action behavior 1 (Color Picker with editor mode enabled).
2. Press the shortcut to open picker, pick a color and show it in editor.
3. Open settings and configure the action behavior 2 (Editor).
4. Press the shortcut to open editor. => The last picked color is missing.

I also not able to clear the colors in history permanently.
After switching the mode, the removed colors reapear.

[martinchrzan]

This is somewhat expected, you should not have settings opened at the same time as editor - they are both using settings.json - settings page only loads that settings.json when that page is opened and it holds its version - then you go to editor change something which changes settings.json, but settings window does not know about those changes and when you select different behavior it overwrittes settings.json with its old version it got when settings opened.
This issue is not ColorPicker specific, but it will happen in all other modules - you should not use module at the same time as you are changing settings.

[htcfreek]

This is somewhat expected, you should not have settings opened at the same time as editor - they are both using settings.json - settings page only loads that settings.json when that page is opened and it holds its version - then you go to editor change something which changes settings.json, but settings window does not know about those changes and when you select different behavior it overwrittes settings.json with its old version it got when settings opened.
This issue is not ColorPicker specific, but it will happen in all other modules - you should not use module at the same time as you are changing settings.

Okay this makes sense. I think if we can became a general warning implemented or if we can get a general solution to prevent this type of bugs in all PTs.

@JolyonJostar
Is the issue resolved for you with the answer from @martinchrzan ?

[martinchrzan]

I will have a look into this so settings would always use the latest settings.json before making any change.
@JolyonJostar was this what happened to you, or you didn't have settings open? If not, then we have some other issue as well.

[htcfreek]

I will have a look into this so settings would always use the latest settings.json before making any change.

Can we use a different json for the history? Then we can't get this problem.

[JolyonJostar]

I will have a look into this so settings would always use the latest settings.json before making any change.
@JolyonJostar was this what happened to you, or you didn't have settings open? If not, then we have some other issue as well.

yes it's, but i think it's not a good experience for user,can we make it auto save when switching or an individual json?

[JolyonJostar]

I will have a look into this so settings would always use the latest settings.json before making any change.

Can we use a different json for the history? Then we can't get this problem.

a different json or auto save can fix this issue