PowerToys Run Mode Crashes from ctrl+shift+tab

[soyfrien]

ℹ Computer information

• PowerToys version: 0.21.1.0
• PowerToy Utility: PowerToys Run
• Running PowerToys as Admin: No
• Windows build number: 20211.1000

📝 Provide detailed reproduction steps (if any)

1. Set PowerToys Run shortcut to ctrl+shift+space
2. ctrl+shift+space
3. ctrl+shift+tab will crash PTRun

✔️ Expected result

Key combo is ignored.

❌ Actual result

PowerToys Run crashes and dumps trace log.

📷 Screenshots

Logs

Error Message

Version: 0.21.1.0
OS Version: Microsoft Windows NT 10.0.20211.0
IntPtr Length: 8
x64: True
Date: 10/05/2020 18:09:57
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at PowerLauncher.ViewModel.ResultsViewModel.SelectPrevTabItem()
   at PowerLauncher.ViewModel.MainViewModel.<InitializeKeyCommands>b__24_5(Object _)
   at PowerLauncher.ViewModel.RelayCommand.Execute(Object parameter)
   at PowerLauncher.MainWindow.Launcher_KeyDown(Object sender, KeyEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndKeyboardInputProvider.ProcessKeyAction(MSG& msg, Boolean& handled)
   at System.Windows.Interop.HwndSource.CriticalTranslateAccelerator(MSG& msg, ModifierKeys modifiers)
   at System.Windows.Interop.HwndSource.OnPreprocessMessage(Object param)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Log File

2020-10-05.txt

[soyfrien]

Same behavior in version 0.23.0:

Log File
2020-10-05.txt

Error Message

Version: 0.23.0.0
OS Version: Microsoft Windows NT 10.0.20211.0
IntPtr Length: 8
x64: True
Date: 10/05/2020 18:35:36
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at PowerLauncher.ViewModel.ResultsViewModel.SelectPrevTabItem()
   at PowerLauncher.ViewModel.MainViewModel.<InitializeKeyCommands>b__24_5(Object _)
   at PowerLauncher.ViewModel.RelayCommand.Execute(Object parameter)
   at PowerLauncher.MainWindow.Launcher_KeyDown(Object sender, KeyEventArgs e)
   at System.Windows.Input.KeyEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndKeyboardInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawKeyboardActions actions, Int32 scanCode, Boolean isExtendedKey, Boolean isSystemKey, Int32 virtualKey)
   at System.Windows.Interop.HwndKeyboardInputProvider.ProcessKeyAction(MSG& msg, Boolean& handled)
   at System.Windows.Interop.HwndSource.CriticalTranslateAccelerator(MSG& msg, ModifierKeys modifiers)
   at System.Windows.Interop.HwndSource.OnPreprocessMessage(Object param)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

[arjunbalgovind]

@ryanbodrug-microsoft @crutkas I can repro this. I can start looking at this since it throws an exception window(PT Run doesn't crash though and execution can continue). It should be a simple fix of adding null checks.

[crutkas]

Added in 0.25. https://github.com/microsoft/PowerToys/releases/tag/v0.25.0