Powertoys: [Watson][82069be4-35c3-350c-257b-2e04674b7ffe]NULL_POINTER_READ_c0000005_KeyboardManager.dll! mtx_do_lock

[ryanbodrug-microsoft]

Generated issue from Watson
Watson Link: https://watsonportal.microsoft.com/Failure?FailureSearchText=82069be4-35c3-350c-257b-2e04674b7ffe
ADO Link: https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems#id=26796984&triage=true&fullScreen=true&_a=edit
Process: powertoys.exe,
Module: keyboardmanager.dll

[ryanbodrug-microsoft]

@arjunbalgovind : There are over 150 hits on this one. It would be a good one to look at next. It first showed up on 6/6/2020

[arjunbalgovind]

Already started looking into it today! 😄

[arjunbalgovind]

As per the info from @saahmedm who had reproduced this once, the crash seemed to occur while pressing the OK Button on the Type dialog window, and before this happened his system was running very slow so it could be a concurrency related issue. This stackoverflow question mentions that they hit the same exception at the exact same line as what I found from the watson cabs, however it points to the std::mutex STL so I couldn't get an exact line in the PT source code which caused the crash.

This may or may not be fixed in #6583 since a change is made to the unregistering of key delays which was earlier occurring on extra threads with a mutex. @ryanbodrug-microsoft @crutkas how do you suggest I proceed with this? I was thinking of putting this on hold since apart from the information above I haven't gotten closer to getting a repro or finding a potential crash source. Instead I could start working on one of the other issues on the milestone.

[ryanbodrug-microsoft]

Let's mark it as needs repo, and deprioritize until we can verify if #6583 fixes the issue.

[arjunbalgovind]

Adding the fix-committed tag on this since it should be fixed in theory by #7206. But can validate this only after the next release by checking Watson.

[arjunbalgovind]

@crutkas we could add this to the 0.25 release project so that we can validate it when that is released.

[crutkas]

Added in 0.25 release https://github.com/microsoft/PowerToys/releases/tag/v0.25.0