Powertoys: Keyboard Manager shortcut remap only remains active when all keys are pressed

[martinsstuff]

Environment

Windows build number: [Version 10.0.18363.836]
PowerToys version: 0.18.0
PowerToy module for which you are reporting the bug (if applicable): Keyboard Manager

Steps to reproduce

Remap Alt + Space to Win + Space

Expected behavior

The Keyboard language selector works as usual, it stays open when only holding the modifier key so you can slowly rotate through the available options.

I.e. As long as the previous keys of the shortcut are still being held the shortcut will remain active, only when either releasing the keys or pressing another button not part of the shortcut will it release or change the shortcut remap.

Actual behavior

The selector is kinda broken as the window will close immediately when releasing the space key while still holding the modifier key.

[arjunbalgovind]

Can repro easily. This seems to be happening because of the current logic that we have which is like this:

• If Alt+Space is remapped to Win+Space and the user presses Alt+Space and then lets go of Space we immediately revert back to Alt being held down logically. This was done so that a user can continue pressing something like Alt+Tab (or another other Alt shortcut) without having to let go of Alt.
  Maybe the logic has to be tweaked such that we switch back to Alt only if some other "non-remapped" shortcut is pressed.

[crutkas]

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release