Powershell: Zip release packages should not have PDB files

Created on 8 Apr 2019  路  8Comments  路  Source: PowerShell/PowerShell

Steps to reproduce

Expand any PowerShell package release.

Expected behavior

No PDB files should be present.

Actual behavior

Multiple PDB files are present in the package. They also differ according to the bit-ness of the package.

Environment data


Name                           Value
----                           -----
PSVersion                      6.2.0
PSEdition                      Core
GitCommitId                    6.2.0
OS                             Microsoft Windows 10.0.18875
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0鈥
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
Area-Maintainers-Build Issue-Bug

All 8 comments

In 7.0 Preview4 I see only two PDB files
image

/cc @adityapatwardhan @SteveL-MSFT Can we close the issue?

The .tgz also has the same pdbs. Seems like when we tar and zip, we should just exclude pdb files.

7.0.0-rc.2-linux-arm32.tar.gz package has these:

root@pi:~# ls -1 ./PS700RC2/*.pdb
./PS700RC2/Microsoft.PowerShell.Commands.Management.pdb
./PS700RC2/Microsoft.PowerShell.Commands.Utility.pdb
./PS700RC2/Microsoft.PowerShell.ConsoleHost.pdb
./PS700RC2/Microsoft.PowerShell.MarkdownRender.pdb
./PS700RC2/Microsoft.PowerShell.SDK.pdb
./PS700RC2/Microsoft.PowerShell.Security.pdb
./PS700RC2/pwsh.pdb
./PS700RC2/System.Management.Automation.pdb

tar has --exclude that can exclude the pdbs, but Compress-Archive doesn't have such a capability currently. Although you can pipe files to Compress-Archive, it doesn't work correctly with folders so you can't use that to exclude pdbs. Seems ok to just delete the pdbs from the source location prior to packaging...

Oh, it seems we have so many issues that lost important ones. Maybe we should triage every new one and include in GitHub projects and set a milestone. I any case the issue workflow should be improved.

Seems ok to just delete the pdbs from the source location prior to packaging...

Maybe it is better to _move_ them in a folder because we seem have a request publish pdb-s too?

I believe the request is to publish symbols separately, so we need a package that has all the symbols for a released build making it easier to debug issues. So for that, I agree it would make sense to copy all the symbols to a separate folder and build a separate package for that.

Was this page helpful?
0 / 5 - 0 ratings