Powershell: Linux alpha.18 install script is deploying alpha.17

[latkin]

https://raw.githubusercontent.com/PowerShell/PowerShell/v6.0.0-alpha.18/tools/download.sh

[latkin]

Looks like doc/script updates for .18 were merged after the release was cut: https://github.com/PowerShell/PowerShell/compare/v6.0.0-alpha.18...master

[joeyaiello]

Hmm, I don't know how tricky it is fix the tag, paging @PowerShell/powershell-maintainers

[latkin]

Maybe best to just create a .19 tag/release and delete the .18 release

[vors]

This is expected, because we creating the tag, before building the packages.
See the release instruction doc.

We can try to revisit this process, but we usually want to make a tag and grab the build from CI, so we need working download.sh to get it out. That creates a chicken and egg problem and we just using the previous pre-built for the download.sh.

I propose to remove the tag version pinning from the install instruction to avoid confussion. It safe to get the version from main and it would allow maintainers update one less place, when making the release.

[lzybkr]

I don't think it's expected - we're not pushing a tag until the release is ready to publish.

All of the changes are made in a branch, the build server builds the branch, we publish those binaries - no CI is needed. @raghushantha can confirm.

[TravisEz13]

@lzybkr Alpha.17 has the same issue. We haven't updated the download script until the binaries have been published. I talked to @daxian-dbw during the release and pointed out this issue i.r.t. the docker files. I think we should fix the process for the next release. Once download.sh is changed, Linux won't build until we publish the next build. We need to put some thought into how to make the work properly. I suggest using the repositories where available in download.sh.

[raghushantha]

@lzybkr Correct. The Release system does not use download.sh. It clones/builds based off the tag and packages the binaries.

[DonPwrShellHunt]

The link
https://raw.githubusercontent.com/PowerShell/PowerShell/v6.0.0-beta.1/tools/download.sh
points to v6.0.0-alpha.18. No surprise really (based on the description of this issue), but it delayed my install of beta.1 on macOS since the first documented beta install instructions I saw used download.sh.

[joeyaiello]

@DonPwrShellHunt but that's because you're grabbing the download.sh in the beta tag. If you use the download.sh from master, you'll always get the latest release build: https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/download.sh

[latkin]

@joeyaiello If the official team guidance is "use download.sh from master to get the latest release package" then I recommend you update your published installation documentation to say so. At the moment, your docs in the master branch are telling people to run the wrong script: https://github.com/PowerShell/PowerShell/blob/master/docs/installation/linux.md

[andschwa]

Why don't we just update download.sh to add the relevant package repository, and install the package from there? No more fussing with downloading a particular file from GitHub.

[joeyaiello]

Now that is...totally valid. We should do that. 😄

@TravisEz13 that sound reasonable to you?

[joeyaiello]

@andschwa I'm good w/ that too, but it sounds like more work. Doc update might be the way to go in the meantime.

[andschwa]

@joeyaiello it really wouldn't be. We already have all the code to do it in the form of instructions on the installation documentation page.

[joeyaiello]

So you got this then? ;)

Also, would that mean that we would install Homebrew and Homebrew-Cask on macOS users?

[andschwa]

Also, would that mean that we would install Homebrew and Homebrew-Cask on macOS users?
I wouldn't install home brew, but if it's there, we could use it to install the cask version.

I'm also a fan of just deleting this script entirely (I tried pre-launch), it's a maintenance nightmare.

[joeyaiello]

There is a long tail of scenarios that are using it in the wild. I can't enumerate them all off-hand, but I've dealt with enough users that need it that I think it's worthwhile to continue maintaining.

[andschwa]

I know 😢

[TravisEz13]

Yeah, there is a PR to move to using the repo's but it got stalled.
https://github.com/PowerShell/PowerShell/pull/3608/files

[joeyaiello]

Just came back once to post that once I remembered it was there. Thanks, @TravisEz13

[iSazonov]

Seems we could close the old issue.

[TravisEz13]

I agree. We have updated the build process and the docs are mainly separate from the repo now.