Powershell: Xaml and other resources are not embeded into Microsoft.PowerShell.GraphicalHost and Microsoft.PowerShell.Activities.dll

[daxian-dbw]

Steps to reproduce

1. Build full PS in Github.
2. Open the generated Microsoft.PowerShell.Activities.dll and Microsoft.PowerShell.GraphicalHost.dll in ILSpy.exe.
3. Open the Microsoft.PowerShell.Activities.dll and Microsoft.PowerShell.GraphicalHost.dll from the GAC.
4. Compare the items in "Resources" folder that are displayed in ILSpy.exe.
   

   Expected behavior

You will see for each of the DLLs from GAC, there is a "*.g.resources" item. Those resources are expected to be embedded in the DLLs produced in Github.

Actual behavior

Those resources items are missing from the DLLs produced in Github.

Environment data

PS:122> dotnet --info
.NET Command Line Tools (1.0.0-preview2-003119)

Product Information:
Version: 1.0.0-preview2-003119
Commit SHA-1 hash: 0708fe095e

Runtime Environment:
OS Name: Windows
OS Version: 10.0.10586
OS Platform: Windows
RID: win10-x64

[vors]

@daxian-dbw do you know a simple test that we can add in test\fullclr?

[daxian-dbw]

I don't know how can we exercise the code path that actually involves loading the xaml resources :(
@chunqingchen do you happen to know a simple test for this?

[vors]

Low-priority, moving it for Future

[chunqingchen]

I'm afraid there's no simple test at hand. looks like this scenario is good for one time verification?

[1RedOne]

Been testing my XAML tools in PowerShell on Linux today and finding that I can't instantiate a XML NodeReader Object.

[iSazonov]

@daxian-dbw Seems we can close the Issue.

[vors]

@daxian-dbw is it really won't fix or it's not an issue anymore because the dotnet cli changed the behavior? If we don't embed them, that's probably a change of public interface. I guess nothing but PowerShell ISE should depend on it, but still may be worth to throw breaking change label at it and mention in the changelog.

[iSazonov]

@vors Graphical host and WorkFlows was removed from the repo.