Popper-core: Making popper.js XHTML-friendly
popper.js 1.12.9 doesn't support XHTML, I mean W3C-validated XHTML running in XHTML mode, yet.
To support XHTML-mode, I modified popper.js source file, replaced all .nodeName with .nodeName.toUpperCase(), and finally my Bootstrap dropdown did work.
Any plans to add XHTML support?
fuweichin
All 16 comments
That's the first time someone asked about support for it. If enough people vote for this feature we can add it for sure.
FezVrasta
on 6 Mar 2018
I have the same problem when using Bootstrap dropdowns. Here is a minimal example that fails:
~
~
Here is the error that occurs when trying to open the dropdown:
Error: regexp too big at popper.min.js:4:602
Artefact2
on 11 Mar 2018
I have a similar problem with xhtml. It does not support html in for example title attribute. Is there a way to display a tooltip with custom html and not using it with the title attribute? for example for the use together with jsf
Prideth
on 31 May 2018
I have exactly the same problem with the Bootstrap dropdowns. At least, it should be mentioned in the BS documentation.
in XHTML, Bootstrap dropdowns work fine within a navbar, but not outside. This is quite confusing. After further readings, I found out in the BS documentation that popper.js in not used In the first case.
ylebhan
on 2 Jul 2018
Why are you guys using XHTML?
atomiks
on 3 Jul 2018
For me, it is just a very convenient way to ensure that my code follows strict structural and syntactic rules. And it doesn't require any additional effort.
ylebhan
on 3 Jul 2018
@atomiks And why are you using HTML? Please let's not start a flame war. It boils down to personal preference, mainly due to the toolchain and parsers being different for both.
Artefact2
on 3 Jul 2018
I also have similar problem of dropdown with XHTML. Are we going to include in upcoming release ?
neel5481
on 21 Nov 2018
The PR is stuck. But the "next" branch will support it
FezVrasta
on 21 Nov 2018
Since you closed #671, does that mean that you managed to get this working?
ExE-Boss
on 22 Apr 2019
No, I just closed some PRs that were outdated and with failing tests.
FezVrasta
on 22 Apr 2019
In which Release will xhtml work? In our project we use JavaEE with JSF and are stuck at the moment.
Without xhtml support we can not use popper
Prideth
on 13 Aug 2019
@Prideth support for XML is not planned at the moment, if someone wants to send a PR to add it I'm okay with it, but the PR must be of good quality
FezVrasta
on 13 Aug 2019
This is now supported in v2
FezVrasta
on 22 Nov 2019
The company I work for uses Popper.js for glossary definitions in its ebooks. While Popper.js works on our own proprietary ebook platform, it does not work on other online readers that display the pages as XHTML.
Would it be possible to have the solution for supporting XHTML released with a 1.x.x tag? We're hoping to have this fix on a stable version, just so that it doesn't need to be updated across every ebook we publish once 2.0 moves out of alpha or beta.
I found that updating the following in attachToScrollParents resolves the issue (I believe this was mentioned above):
var isBody = scrollParent.nodeName.toUpperCase() === 'BODY';
I can submit a pull request if needed.
grumbaut
on 17 Dec 2019
I’m sorry, there are several places where things should be changed to properly fix it. Unless a clean fix is provided (following what I did in v2) I don’t plan to merge PRs to fix this issue on v1.
Code stability is more important than fixing this bug at the moment.
FezVrasta
on 17 Dec 2019
Related issues
nainardev
·
3Comments
skitterm
·
5Comments
FezVrasta
·
5Comments
c0bra
·
5Comments
QJan84
·
4Comments