Popcorn-desktop: Subtitle and movie cover issue when using download button

[dutchy1001]

Operating System Version:
Windows 10

Download date:
In the last week (Build 437)

Download url (optional):
https://ci.popcorntime.app/job/Popcorn-Time-Desktop/437/

Expected Behaviour

When using the download button the subtitles and movie covers should download aswell
...

Actual Behaviour

It download the movie but not the subtitles or cover
...

Steps to reproduce the behaviour

1. Set a default subtitle in the settings ( I tried Dutch and English)
2. Choose a movie to download.
3. Check download folder, Movie and a JPEG but no subtitle or cover file. (It does somtimes add an "empty" .srt file, see attachment)

Screenshot of error from developer console (F12 key (win & linux) or ⌘+⌥+i (macOS), then 'console' tab) (optional)

Guns.Akimbo.2019.1080p.WEBRip.x264.AAC5.1-[YTS.MX].srt.txt

Console output.txt
Dont think there is an error about the subs here.

[kiriles90]

@dutchy1001 do you know if they were downloaded in any previous builds or not downloading the subtitles was always the case with the seedbox feature?
From a quick look it seems like its the latter though I might be wrong so just making sure.

[dutchy1001]

it was in previous builds but forgot about it till few days ago as I was asked to get a movie for a family member. Not sure how far back this was.
If time lets me I will try and find out when the issue started.

[kiriles90]

Yeah, seem this was never added, will try and see if its easy to implement without making a mess when I get some time.

[dutchy1001]

great, saves me then install/uninstall multiple versions to find the first build it happened with.

[dutchy1001]

Any more progress on this bug?
Just downloaded 2 episodes to watch later but it still skipped the subs download.

[kiriles90]

No idea if anyone else looked at it but I didnt. There is #1452 that adds it but it also adds a lot of other stuff that either have been fixed, changed and/or have conflicts and cant be merged. The OP never responded to my message either so I guess someone else will either have to separate the subtitles feature or rewrite it. Not forgetting it though, I'm also interested in fixing this.

[kiriles90]

Editing above to include movie covers since now after #1920 they are also being saved when using the 'Watch now' button and its pretty much the same thing thats required for them to also be saved with the 'Download' button as is for the subtitles.