Polls: Polls 1.0.0 RC3 is out

[dartcafe]

Polls 1.0 is feature complete. Just bug fixes will be done. Best will be a fresh install or an update from the last release 0.10.4.

❗️ Please remember, this is still a test version and a pre-release. So please do not use on a production system.

This is hopefully the last testversion before the stable release

Download here: https://github.com/nextcloud/polls/releases/tag/v1.0-rc3

[herrmannsdorfer]

Good job! I did a quick test and found the following remaining issues:

• in table layout the column headings are misaligned in fav votes (Safari only).
  

• missing "remember last state" when switching view (was working in beta). That would mitigate the design change with default view - not every user likes the new design ...

• invitation mail is sent, activity mails are not. no err in log. no cron err. EDIT: A few minutes later (cron?) the log shows:

  [PHP] Error: Undefined index: userEmail at /var/www/nextcloud/apps/polls/lib/Controller/ShareController.php#156

• public poll shows blank page.
  

• new polls are not automatically listed in "All polls" (refresh needed, was working in beta).

• icons missing in "all polls" list. Only icon for text based polls are shown.
  

[brtptrs]

In our test installation public links result in an empty page. Firefox shows this error:

[herrmannsdorfer]

Just checked public poll with FF again: @brtptrs is right. I edited my comment above accordingly.

[dartcafe]

@herrmannsdorfer

in table layout the column headings are misaligned in fav votes (Safari only).

Checked on Firefox, Chrome and Safari. Looks Ok for me in all three browsers.

missing "remember last state" when switching view (was working in beta). That would mitigate the design change with default view - not every user likes the new design ...

last state was never remembered, I think it looks like, because,if you change from poll to poll, the state remains, as well as the sidebar state.

invitation mail is sent, activity mails are not. no err in log. no cron err. EDIT: A few minutes later (cron?) the log shows:

Yep. The background job had a bug, so it stops every time. Alreaday fixed this yesterday.
But there seems to be a bug in the background job execution (or it's by design), because on every cron execution, only one job is executed, although the notification job is set to be executed every five minutes (or seconds, docs are a little bit confusing). In the end, the job should be called on every cron execution, but it don't. I will check this afterwards.

public poll shows blank page.

fixed. also @brtptrs

new polls are not automatically listed in "All polls" (refresh needed, was working in beta).

fixed

icons missing in "all polls" list. Only icon for text based polls are shown.

The calendar icon is alway generated as icon-calendar-fff (icon is white), All other icons are ok. As a workaround, I hardcoded it to black for the moment.

@jancborchardt Any idea, why this only happens to the calendar icon?
https://github.com/nextcloud/polls/blob/344824b685eee2e26822a618a8a67814671ae2b4/src/js/components/Navigation/PollNavigationItems.vue#L61-L65
The icon-toggle-list class returns

.icon-toggle-filelist {
    background-image: var(--icon-toggle-filelist-000);
}

The icon-calendar class returns

.icon-calendar {
    background-image: var(--icon-calendar-fff);
}

And @jancborchardt I think, we could need some UX experience for the UI. Any suggestions?

[dartcafe]

Updated to RC2
https://github.com/nextcloud/polls/releases/tag/v1.0-rc2

[herrmannsdorfer]

in table layout the column headings are misaligned in fav votes (Safari only).

Checked on Firefox, Chrome and Safari. Looks Ok for me in all three browsers.

Maybe a Safari bug. When I refresh the cache, zoom in and out its sometimes there sometimes not.

missing "remember last state" when switching view (was working in beta). That would mitigate the design change with default view - not every user likes the new design ...

last state was never remembered, I think it looks like, because,if you change from poll to poll, the state remains, as well as the sidebar state.

I will open an issue for that. Maybe a view preference would be a nice enhancement.

Public votes are working now, but in FF you cannot comment (Chrome works):

[brtptrs]

It seems posting the first comment is blocked from the main window. After posting a comment from the right sidebar I can post further comment from the main (middle) pane.
Edit:
Participants can't comment at all, I think.

[herrmannsdorfer]

But in a public poll there is only a main view, no left or right sidebar.

[brtptrs]

The links to submissions, generated via public polls, lead to a "File not found" error.
Edit:
/index.php/s/BlWPtihjrrjWa8x8o6nHr
is shown and does not work
/index.php/apps/polls/s/BlWPtihjrrjWa8x8o6nHr
Does work

[brtptrs]

Error shown when trying to post a comment as a participant:

[jancborchardt]

And @jancborchardt I think, we could need some UX experience for the UI. Any suggestions?

@dartcafe cool! :) Yes, definitely plenty of suggestions, but this week is a bit busy with release preparations for 18. cc @nextcloud/designers meanwhile.
In general it’s great to see all the nice work towards simplifying the interface, and we can for sure do more there. :)

[dartcafe]

but this week is a bit busy with release preparations for 18

I was sure about that. No hurry. UX should be improved after version 1.0. I want to get it out with NC 18. We can make it better afterwards.

[dartcafe]

/index.php/s/BlWPtihjrrjWa8x8o6nHr
is shown and does not work
/index.php/apps/polls/s/BlWPtihjrrjWa8x8o6nHr
Does work

Grpfl... Will check and fix that later, as well as the commentings.
BTW: The comments sidebar is obsolete, so I will remove that.

[herrmannsdorfer]

invitation mail is sent, activity mails are not. no err in log. no cron err. EDIT: A few minutes later (cron?) the log shows:

Yep. The background job had a bug, so it stops every time. Alreaday fixed this yesterday.
But there seems to be a bug in the background job execution (or it's by design), because on every cron execution, only one job is executed, although the notification job is set to be executed every five minutes (or seconds, docs are a little bit confusing). In the end, the job should be called on every cron execution, but it don't. I will check this afterwards.

I received a bunch of notifications exactly 5 hrs after the install of RC2.

System cron job for my NC instance runs every 5 minutes - if that info helps debugging. Last cron related err in log was while RC1 was running.

Never had these err until Polls beta or RC.

[dartcafe]

The comments component behaves strange. If it is placed in the side bar, everything works, as it should. Putting it to the main view this gets weird. Commenting throws that error and the vote reloads. There must be something, which I don't see. For the moment I placed it back to the side bar for public and non public polls.

[dartcafe]

I received a bunch of notifications exactly 5 hrs after the install of RC2.

@herrmannsdorfer Are you sure, you replaced the app correctly. I had this log entries in RC1, but fixed it in RC2. I do not get these errors anymore... I am testing on NC18

[herrmannsdorfer]

I received a bunch of notifications exactly 5 hrs after the install of RC2.

@herrmannsdorfer Are you sure, you replaced the app correctly. I had this log entries in RC1, but fixed it in RC2. I do not get these errors anymore... I am testing on NC18

Notifications are resolved with RC2.

Sorry, maybe a misunderstanding. As said: The last cron related err were with RC1. The delayed notifications originated from RC1 tests and they came exactly 5 hrs after RC2 went live on my server (for whatever reason). Server is running NC17. Testing with RC2 now results with invitations and activity notifications sent within the 5 min timeframe of configured background job calling cron.php.

[dartcafe]

Ehm. yes. Now I see. Good to hear. So it seems to work as expected (nearly)

[dartcafe]

Now I understand. The delay is because failed Jobs will be paused 12 hours by the core system.

[dartcafe]

Updated to RC3.

[dartcafe]

@jospoortvliet We are just releasing polls 1.0. Comming back to your offer in this issue: https://github.com/nextcloud/polls/pull/385#issuecomment-429538593 What about some promotion?

[dartcafe]

CC @v1r0x