Polls: Switchin from scss to css.

Created on 21 Nov 2017  路  7Comments  路  Source: nextcloud/polls

There are some issues regarding non standard installations of NC. So we should switch to css for the releases, until scss support in NC is complete for this installation variants. Additionally this issue would support NC11 and OC as well.

awaiting feedback bug server

Most helpful comment

All 7 comments

How do other apps like Contacts or Deck handle this problem? Sounds like a rare case 馃 perhaps we could implment a fallback?

The problem seems to be inside the scss precompiler in NC which compiles background-image: url('../img/open-voted-vote.svg'); to background-image: url('../../../apps/polls/css/../img/open-voted-vote.svg'); pointing from the css directory.

If I compile the scss locally the precompiler leaves it untouched.

I have no idea how to have a fall back strategy. Seems, that the functions in core have to be updated. Until then, we can switch to native compiled css.

Affected issues: #200, #249 and some more remarks about that in some unusal installations (I don't find the issues or comments in PRs).

@v1r0x: We just need to eleminate the scss files from the releases.
@splitt3r Any change to have a robot which nightly compiles the css files? Maybe for some other jobs too.

Hm i don麓t think so. Perhaps Travis CI could do it but that would be a very hacky solution. Let麓s wait for an answer to https://github.com/nextcloud/polls/issues/249#issuecomment-346048705.

So if https://github.com/nextcloud/server/pull/7257 gets merged we don麓t need to switch 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

khayman123 picture khayman123  路  3Comments

BurtGummer picture BurtGummer  路  3Comments

nextgen-networks picture nextgen-networks  路  6Comments

johnnydvc picture johnnydvc  路  6Comments

dartcafe picture dartcafe  路  4Comments