Pokeapi: Set up CI system

[neverendingqs]

Needs to:

• Host local version of pokeapi
• Run ditto
• Moves files to proper location?
• Set Netlify redirect rules
• Set up headers file?

Tasks:

• [x] performance improvement addressed in #351
• [x] needs ditto in PyPi (https://github.com/PokeAPI/ditto/issues/4)
• [x] Connect to Netlify (https://github.com/PokeAPI/pokeapi/issues/352) (@neverendingqs)
• [x] Configure Netlify (see #356 for details) (@sargunv)

[sargunv]

Netlify's continuous deployment looks like it supports an arbitrary build command, so as long as the timeout is long enough it should be usable. I'd be happy to cook something up once pokeapi is fast.

[sargunv]

@neverendingqs Did you get the OSS Netlify team account set up? If not I'll start working on this on my personal account and migrate when we have it, but if it's already available then we can start right on that one.

At the moment I'm working on some refinements to Ditto that'll improve Ditto's handling of base URLs and make this CI job not need to run a ditto clone on every site update (since it can take some time to crawl all 10k objects).

[neverendingqs]

@sargunv - I have not unfortunately. My last email to them was late afternoon Friday, and I suspected they didn't get to it before the end of their business day. If you could get started by using your personal account that'll be great!

Are you able to add the ditto issues to the PokeAPI - Migration to Static files / Serverless
project? I saw five issues come in, but I wasn't sure if all five were related to the project.

[sargunv]

Sure, I'll add the ones that are related. Some aren't related -- I'm planning on eventually trying to leverage ditto's schema generation to auto-generate an easy to maintain successor to pokekotlin, and perhaps a whole suite of language specific clients.

[sargunv]

The API is up: https://pokeapi.netlify.com/api/v2/

The config. It's deploying from sargunv/ditto until Netlify gets approved by an admin to access this org. Atm, it redeploys whenever ditto is pushed, so once https://github.com/PokeAPI/ditto/issues/9 is complete it'll be always up to date.

I'll transfer it to the team account when that's available.

[tdmalone]

Woww that’s amazing!! Awesome work @sargunv & @neverendingqs :D

I’ve approved Netlify (and Docker Cloud) for access to the org.

I had in my head that the the API would deploy from the pokeapi repo, and we’d instead install ditto and generate static files in the build job. That way the API is naturally up-to-date on every push and ditto is treated as a library. Does it make more sense this way to have ditto as the gatekeeper? As part of PokeAPI/ditto#9 what would be the possibility of kicking off that job whenever pokeapi is pushed to?

[sargunv]

I just did it from ditto for now because it's not using anything outside ditto, but we can move the deploy config to be anywhere that makes sense. Maybe to its own repo.

The update job can be set up to use a webhook to react to pushes. I'll work on the updater job next.

On Sep 9, 2018, at 12:57, Tim Malone [e-mail] wrote:

Woww that’s amazing!! Awesome work @sargunv & @neverendingqs :D

I’ve approved Netlify (and Docker Cloud) for access to the org.

I had in my head that the the API would deploy from the pokeapi repo, and we’d instead install ditto and generate static files in the build job. That way the API is naturally up-to-date on every push and ditto is treated as a library. Does it make more sense this way to have ditto as the gatekeeper? As part of PokeAPI/ditto#9 what would be the possibility of kicking off that job whenever pokeapi is pushed to?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[neverendingqs]

Just to add another option in case it helps, Netlify supports incoming hooks to trigger a new build / deploy.

[neverendingqs]

@tdmalone - can you log into https://app.netlify.com/ and see if you have access? It should be under "All Teams" near the top left.

A Netlify representative told me it should be set up already, but I don't see it on my side. Perhaps only org admins can see it?

[tdmalone]

@neverendingqs Not there 😢 I can only see a team I set up for testing awhile ago:

(And I logged in with GitHub SSO just in case)

I tried going through _Create new team_ but that asks me to select from either the Pro or Business plan.

I'd be surprised if they used GitHub permissions for their team permissions. It'd be cool (and it's what Travis CI does), but given Netlify works with multiple VCS providers I would think it's unlikely?

I'm thinking they need to give you access and then you can add other team members from there...

[neverendingqs]

@sargunv - I have unchecked the last task for now until you can get it set up on the PokeAPI Netlify account. Feel free to change it around if you want to track that task a different way.

[sargunv]

I've transferred it to the PokeAPI Netlify account: https://app.netlify.com/sites/pokeapi/overview