Poetry: Add key to allow fetching submodules for git repos

Created on 9 Nov 2018  路  6Comments  路  Source: python-poetry/poetry

  • [x] I have searched the issues of this repo and believe that this is not a duplicate.

Issue

Currently, git dependencies do not fetch submodules. This makes dependencies like mypy unusable when installing it from git. I don't think fetching submodules should be the default behavior, but it would be nice if git dependencies had the option to fetch them. For instance:

[tool.poetry.dependencies]
# Submodules would not be fetched for sqlalchemy-stubs
sqlalchemy-stubs = {rev = "8b45fc4345778e3f08e8a3b53ff71aaaa775e632", git = "https://github.com/dropbox/sqlalchemy-stubs.git"}

[tool.poetry.dev-dependencies]
# Submodules would be fetched for mypy because of submodules = true
mypy = {rev = "47c25263694bae2a577c15d70d2988db2e8e8584", git = "https://github.com/python/mypy.git", submodules = true}
Feature

Most helpful comment

Maybe Poetry should just always pull submodules for Git dependencies. This would avoid introducing yet another option which would complicate things in the codebase and pulling submodules should not have any side effect that I can think of.

All 6 comments

I currently have the same problem with pocketsphinx, which uses submodules as well. Is there any workaround for now?

is there any progress on this? I am also having this problem :(

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Closing this issue automatically because it has not had any activity since it has been marked as stale. If you think it is still relevant and should be addressed, feel free to open a new one.

+1 to this

Maybe Poetry should just always pull submodules for Git dependencies. This would avoid introducing yet another option which would complicate things in the codebase and pulling submodules should not have any side effect that I can think of.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AWegnerGitHub picture AWegnerGitHub  路  3Comments

Euphorbium picture Euphorbium  路  3Comments

thmo picture thmo  路  3Comments

ghost picture ghost  路  3Comments

thejohnfreeman picture thejohnfreeman  路  3Comments