Pods: List View - Needs Help Text on Edit, Link and Delete icons (and hover)

[PodsBot]

List View - Needs Help Text on Edit, Link and Delete icons (and hover) submitted via Slack by jimtrue

• [x] Decide on "deselect" vs. "remove", add JS translation text if we change
• [x] Help text
• [x] use https://developer.wordpress.org/resource/dashicons/#external for the 'view' icon

[jimtrue]

Specifically because it's not clear if delete would delete from this relationship or delete the item entirely. None of these icons have ever had hover 'help' on File Lists either.

[jimtrue]

Suggestion: use the icon for an eyeball, 'view'. Yes this is a link to the item, but really you're just 'looking' at the post, 'View Entry' makes more sense than 'Link Entry'

Edit <post-title>, View <post-title>, Delete <post-title> from <relationship-field Label>

[jimtrue]

https://developer.wordpress.org/resource/dashicons/#visibility for the 'view' icon

[pglewis]

The eye icon is used to mark the visibility settings for post. By the 'When in Rome' rules we shouldn't use that for "view".

[jimtrue]

That would still be appropriate. WP Core doesn't use the 'link' icon for anything else. And it essentially means 'view' connecting post in a new window

[pglewis]

I'll leave that for @sc0ttkclark to decide.

[sc0ttkclark]

Might I suggest we use this for view instead, if you don't like the Link icon?

https://developer.wordpress.org/resource/dashicons/#external

[jimtrue]

That works ;)

[pglewis]

Tasklist created

[JoryHogeveen]

@pglewis
Any preferences on how to add the current item title to the icon labels?
I don't know of sprintf equivalents for JS other than just str.replace()

[pglewis]

Any preferences on how to add the current item title to the icon labels?
I don't know of sprintf equivalents for JS other than just str.replace()

I think the item title might be data we consider passing into the field options from PHP, already translated

[JoryHogeveen]

True, but do you want to just append it to the current label or something?
Example: Delete <post-title> from <relationship-field Label> will require some sprintf feature

[pglewis]

Is this for the hover text? Perhaps we can just simplify and use "Edit", "View", "Remove" without the title.

[JoryHogeveen]

Fine with me, @jimtrue ?

[pglewis]

I don't think there is any ambiguity that including the title or label resolves, it's clear what you'll be editing/viewing/removing.

The remove X might have a small chance of confusing someone on the function ("will it _delete_ the item??").

[jimtrue]

Yep, the Remove is the only one that really needs clarity.

[pglewis]

I've switched to "Deselect" rather than "Remove" for the title (help text). If everybody is good with that, we just need to add it to the JS translation strings.