Pods: Editable Titles in Multiple File Upload fields are no longer 'editable'

[PodsBot]

Editable Titles in Multiple File Upload fields are no longer 'editable' submitted via Slack by jimtrue

[jimtrue]

Reference from this Forum Post: https://wordpress.org/support/topic/cant-update-title-for-images-in-file-image-video-field/

And verified locally on a 2.x version of Pods. Looking for update from Forum post as to which version he had prior to update that works.

[jimtrue]

Confirmed from post author that 2.6.4 was working version. Downgraded to 2.6.4 and editable titles are working. Will apply patches inbetween to see where it stops working to help isolate the issue.

[jimtrue]

Confirmed patch 2.6.8 broke 'editable titles' in File Upload Field. Worked perfectly 2.6.4-2.6.7

[sc0ttkclark]

May be related to the lines here: https://github.com/pods-framework/pods/pull/3952/files#diff-a60430f6f41bd2124937a30b189634adL409

[jimtrue]

Should clarify, you can 'edit' the titles, but your changes are not saved.

[sc0ttkclark]

Looks like it was this:
https://github.com/pods-framework/pods/pull/3952/files#diff-3674eeced1a3895af87f92459270f228R3777

[jimtrue]

@JoryHogeveen I think this was your edit above ^^ Can you verify?

[JoryHogeveen]

@jimtrue Nope: https://github.com/pods-framework/pods/commit/3899b8614df8eccc5c540a64614e70de049f3059

[jimtrue]

@sc0ttkclark Any idea why code from 8/12/2016 would suddenly break this functionality?

[pglewis]

Looks like it was this:
https://github.com/pods-framework/pods/pull/3952/files#diff-3674eeced1a3895af87f92459270f228R3777

Confirmed that changing $value_ids to $values straightens it out. The change that was made was confirmed to fix another issue, however:

3477

3720

[jimtrue]

Is there a way to isolate the branch back and see if it it retains the fix and doesn't break the other two items? Or was that the only change added that fixed #3477 and #3720?

[jimtrue]

I'm happy to test the 3 conditions, because I have a pod setup for that and can test on it easily.

[pglewis]

Going to punt this to @sc0ttkclark for the moment because it's one of those kinds of fixes. Punt back to me if there's no bandwidth, but do it soon if it's to remain on 2.6.9.

[sc0ttkclark]

On it tonight

[jimtrue]

Per discussion from this forum topic at WordPress.org, this is still an issue:
https://wordpress.org/support/topic/cant-update-title-for-images-in-file-image-video-field/#post-9193848

[n0index]

Hi!
As I wrote, the problem with updating fields in the version of Pods 2.6.8 I decided to rollback this change - https://github.com/pods-framework/pods/commit/3899b8614df8eccc5c540a64614e70de049f3059

Everything worked fine until I updated the version of Pods on 2.6.9
To verify the work after the update, I updated the first field in the post and it was updated.
A few days later I saw the outdated names of the photos, I began to test and realized that only the first field was updated. The second and the rest are not updated.

The previous fix does not work, because In the code, there have been more serious changes than changing one line.

[jimtrue]

Verification: First file's title is updated, remainder are not. @sc0ttkclark you did mention this was kind of a hacky fix that 2.7 would probably eradicate.

[sc0ttkclark]

That's odd, because the work in #4264 reverts the changes in https://github.com/pods-framework/pods/commit/3899b8614df8eccc5c540a64614e70de049f3059 in a way that maintains compatibility with other field types. File fields should continue passing $values essentially, so I wonder what's going on here.

[n0index]

Guys, unfortunately I can't wait for fix more, I need to work with the site.
Can you please tell me, can I upload version 2.6.8 instead of 2.6.9 to site?
Will there be any conflicts?

[jimtrue]

@n0index The latest version (the 2.x branch of Pods) has the fix for this included. I tested this locally and it worked perfectly, so if you could test and verify that would be helpful.

You can get the latest branch version at https://pods.io/latest/

Fixed by #4314

[jimtrue]

@n0index 2.6.8 is the version that actually broke the editable title option, so the above latest patch will include 2.6.9 and the fix for the editable titles. We'll be pushing this hopefully to live in the next week, but we're researching another hot issue that will be incorporated first.

[n0index]

@jimtrue Thank you so much!
Latest version works fine!

[JoryHogeveen]

I still have this error with multiple files.
The first title in the list is changed but the others aren't.

[jimtrue]

@JoryHogeveen Did you pull down the current branch? I just tested this locally to verify and editable file titles works with multiple images, not just the first in the list but all of them and they're being updated in the Media Library.

[JoryHogeveen]

Not the latest 2.x. This was on a live site running 2.6.9. Since this issue was fixed on 2.6.9 I thought I didn't need to pull 2.x. Will do asap.

[jimtrue]

Right it was still broken in 2.6.9, fixed by the fix noted above merged in 2.x

[JoryHogeveen]

Works, thanks! :)