Pocketmine-mp: Trying to use /enchant with a non-existent or non-implemented enchantment causes Protection to be applied instead

[asyncthreading]

Issue description

Every enchant u try to add to a item it puts Protection instead.

Steps to reproduce the issue

Get an item, (A sword) try to do /enchant name sharpness(id 9) 1

OS and versions

• PocketMine-MP:Latest(Branch Master)
• PHP:7.0.19
• Server OS:Linux Ubuntu
• Game version: PE/Win10 (delete as appropriate):PE

Crashdump, backtrace or other files

[asyncthreading]

Then it needs a fix..

[TheDiamondYT1]

@akaSnapy It is not a bug, it's just not implemented yet.

[dktapps]

Technically speaking it is a bug, it's unexpected behaviour. It should tell you the enchantment doesn't exist, not apply a completely different enchantment. This bug is fixed on the api3/blocks branch.

[asyncthreading]

It may be fixed, but i can't git clone that branch, smh.

[ghost]

Im laughing hard rn bc Everyone said it was not a bug and then Dylan comes
and say its a bug. Lol XD

On Jun 6, 2017 2:28 AM, "TheBlazed" [e-mail] wrote:

It may be fixed, but i can't git clone that branch, smh.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pmmp/PocketMine-MP/issues/1012#issuecomment-306266115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARW33WIK6_Z1QvF2vLCZMuHSQSPmtyE9ks5sBEjAgaJpZM4NwXfE
.

[TheDiamondYT1]

@Qimie It's not a bug in api3/blocks, however it is a bug in master. This makes us all correct.

Okay, that's enough useless comments 😂

[BrianZP]

So when is this going to be implemented/fixed in the master branch?

[0x15f]

@brianzp whenever api3/blocks is merged into the master branch.

[MichaelM04]

@akaSnapy Linux:

git clone https://github.com/pmmp/PocketMine-MP.git --branch api3/blocks --recursive

[BrianZP]

Are multiple enchantments the same issue? And are they fixed on api3/blocks

[nasiridrishi]

enchants are messed up! at least it was working with advanced kits now that not too!

[Muqsit]

@optimusprime338 That issue was already fixed almost 2w ago: https://github.com/pmmp/PocketMine-MP/commit/fb59b57bdfc4b1b04e079bf4e3d8ec48385a38e5

[nasiridrishi]

It still not working .. only <3 IDs working

[dktapps]

i.e. the enchantments that were registered... which is how it should have behaved from the start. Do read the title.

[nasiridrishi]

Thanks!