Pocketmine-mp: Can't use /enchant with id >= 3

[TanToan99]

Issue description

Cant set effect or enchant for player with enchant id >=3 nd effect id = 6 and 7
Pmmp need update enchant and effect system

• PocketMine-MP: 01a07a0
• PHP: 7.0.4
• Server OS: linux
• Game version: Win10 and mcpe 1.0.3

Crashdump, backtrace or other files

Nothig

• ...

[dktapps]

Closing due to not reproducible. Check your plugins.

[dktapps]

My bad, /enchant command issue. I misread the issue. No such issue occurs with effects though.

[TanToan99]

I can not set effect with effect id = 6 and 7

[sylvrs]

It's because not all enchants aren't registered on PMMP.

[dktapps]

• _not all enchantments are_ registered (just to be less confusing ;))

[sylvrs]

Yeah I forgot to add "not" in front of it, don't know what I was thinking.

[HBIDamian]

Make sure you are using the the item IDs for their purpose.
const TYPE_ARMOR_EXPLOSION_PROTECTION = 3; -- Protection from explosions when wearing the enchanted armor.
const TYPE_WATER_BREATHING = 6; -- Breath under water
const TYPE_WATER_SPEED = 7; -- Travel under water with speed

For ~all~ most PocketMine friendly enchantments, see here https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/item/enchantment/Enchantment.php#L29

[sylvrs]

But only 3 are implemented, check the implementation below. https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/item/enchantment/Enchantment.php#L87

[dktapps]

correct... hence the "not implemented" label.

[sylvrs]

Talking to @TheDeibo 😆

[thebigsmileXD]

So that we dont forget this:

https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/item/enchantment/Enchantment.php#L103 here
GitHub
pmmp/PocketMine-MP
PocketMine-MP - A server software for Minecraft Pocket Edition in PHP

[10:43]
I think that should return null

Xenial
[10:43 AM]
yea

Xenial
[10:43 AM]
it should not succeed with the enchant

Dylan K. Taylor
[10:43 AM]
agreed

[dktapps]

Closing this in favour of #414 and #1012