Pocketmine-mp: Various health-related bugs

[dktapps]

Issue description

• [x] Double hit-animation when taking fall damage (not reproducible as of 1.0.0.16)
• [x] Players taking fall-damage enough to kill them frequently do not have the "You died!" screen displayed, instead staying alive at zero hearts and recovering up to 1 heart.
• [x] Hit-animation when players regain health (health should be set using attributes, not SetHealthPacket) (old client bug)
• [x] Cancelling health regeneration doesn't seem to work (#157)
• [x] No death animation when dying from fall damage (to other players you literally just vanish when you hit the ground)
• [x] Changing a player's max health doesn't update client attributes (client bug?)

OS and versions

• PocketMine-MP: https://github.com/pmmp/PocketMine-MP/commit/2fba1073ddf4965eb5d2bbbbbfb4a5c5f9377db3
• PHP: doesn't matter
• OS: doesn't matter

[robske110]

most bugs are related to the setHealthPacket now only used for killing players/(decreasing health).

[dktapps]

Can anyone reproduce the double hit animation issue? I can't anymore.

[dktapps]

3 is not reproducible as of 1.0.0.16.

[Muqsit]

Small bug. I don't think it's worth a separate issue. Anyways, I'm not off topic.
Player::setMaxHealth($amount) does not update until the player's health has changed (when Player::setHealth() is called)

[dktapps]

Attributes issue, you can resend them manually if it's important to you.

[Muqsit]

Exactly what I'm doing right now.
Thanks, anyways!

[dktapps]

@Muqsit I believe that is a client bug, the server-side code is perfect as far as I can tell. Similar issues can be seen on Realms with the XP bar not updating, so I think that's a client issue.

[dktapps]

4 is due to client-sided health regeneration effects. This would require attribute resending when the regeneration is cancelled by a plugin.

[dktapps]

4 has been reported to Mojang as https://bugs.mojang.com/browse/MCPE-20507 .

[buchwasa]

Just tested on 1.2 beta and 4 is still reproducible on it.

[dktapps]

Read the comments. 4 is a client-sided bug, so there's nothing for us to do about it.

[buchwasa]

I know it was a client bug, I voted on it. Just got a bit confused sorry

[Muqsit]

6th was fixed in 1.2, tested.
A workaround for 1.1 clients is to Player::setHealth(Player::getHealth()) after changing the player's max health.