Pnpjs: Could releases be git tagged to trigger Github notifications?

[pdecat]

Category

• [ ] Enhancement
• [ ] Bug
• [X] Question
• [ ] Documentation gap/issue

Version

Please specify what version of the library you are using: [ 2.0.13 ]

Please specify what version(s) of SharePoint you are targeting: [ tenant.sharepoint.com ]

Expected / Desired Behavior / Question

It would be awesome if releases of this package were git tagged so that people can watch Github releases to be notified of new versions:

Observed Behavior

When new releases are made, there's currently no way I'm aware of to get notifications about it, apart manually watching the CHANGELOG file.

Steps to Reproduce

N/A

[patrick-rodgers]

We don't currently use github releases, would tagging have any effect? You can also follow @m365pnpjs on twitter where we announce the monthly releases.

[pdecat]

Yeah, tags are also triggering notifications nowadays.

[pdecat]

e.g

[patrick-rodgers]

Right on, we'll see about adding tagging to the publish script. Haven't looked at the command in a bit so might add in 2.1.0 which is becoming a big maintenance release for a lot of behind the scenes stuff. If not that one, will try for the next.

[pdecat]

Looking at https://github.com/pnp/pnpjs/blob/version-2/tools/publish/publish-win.bat#L32, the npm version patch command that is used already git tags the version, so the only thing that seems missing is a git push --tags.

See https://git-scm.com/book/en/v2/Git-Basics-Tagging#_sharing_tags

[pdecat]

Submitted #1485

[patrick-rodgers]

Awesome - thanks! We'll have a look and should have it for the next release. Appreciate the help, cheers.