Pnpjs: [2.0.0] sub module: SP-lists

Created on 7 May 2019  路  5Comments  路  Source: pnp/pnpjs

This issue tracks the review and preparation of a sub module for the 2.0.0 project. To finalize a sub-module the follow steps should be performed:

  • [ ] Code review for TODO (do), commented out code (remove), ensure interfaces are prefixed with an "I", or not using await
  • [ ] Ensure every property/method has at least one test
  • [ ] Ensure all of the interface method/properties are commented
  • [ ] Remove comments from class implementation files
  • [ ] Ensure the docs page is updated to mention each method/property with at least a minimal example
  • [ ] Search in closed issue by the label "area: sample" to see if any apply to the module you are review and add those as appropriate to the documentation
  • [ ] Review/compare the code in the 1.x branch to ensure any fixes, updates, or changes are in 2.0

Once complete submit one PR per module for final review. Please make the title match the issue title and reference the issue in the body of the PR. It will then be reviewed so please check back for any feedback or questions.

Most helpful comment

@joakimhogberg and @PopWarner in the same thread. My two main men ;)

All 5 comments

Hi, can I work on this?

Hi @joakimhogberg! :) Absolutely and thank you for your willingness to contribute. 馃憤 Were you able to review the FAQ's? If everything looks good to you, I can remove the "status: help wanted" label and apply the "status: in progress" label.

@PopWarner , yes I've read up on the getting started / contributing documents. Is there anything specific to working on v2 that I might have missed?

I set up my testing enviroment (v2) and added a few unit tests which seems to run fine. I think I feel comfortable enough to get going :)

Fantastic @joakimhogberg! I've updated the "status" label's and it's all yours to start working on my man. Thank you again!! 馃憤 :)

@joakimhogberg and @PopWarner in the same thread. My two main men ;)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jcosta33 picture jcosta33  路  3Comments

simkessy picture simkessy  路  3Comments

pavan2920 picture pavan2920  路  3Comments

DennisGaida picture DennisGaida  路  3Comments

drewcook picture drewcook  路  3Comments