Pnpjs: [2.0.0] sub module: SP-features

Created on 7 May 2019  路  7Comments  路  Source: pnp/pnpjs

This issue tracks the review and preparation of a sub module for the 2.0.0 project. To finalize a sub-module the follow steps should be performed:

  • [ ] Code review for TODO (do), commented out code (remove), ensure interfaces are prefixed with an "I", or not using await
  • [ ] Ensure every property/method has at least one test
  • [ ] Ensure all of the interface method/properties are commented
  • [ ] Remove comments from class implementation files
  • [ ] Ensure the docs page is updated to mention each method/property with at least a minimal example
  • [ ] Search in closed issue by the label "area: sample" to see if any apply to the module you are review and add those as appropriate to the documentation
  • [ ] Review/compare the code in the 1.x branch to ensure any fixes, updates, or changes are in 2.0

Once complete submit one PR per module for final review. Please make the title match the issue title and reference the issue in the body of the PR. It will then be reviewed so please check back for any feedback or questions.

All 7 comments

I would like to work on and complete the tasks for this sub module. @juliemturner @simonagren @PopWarner.

Thank you @RamPrasadMeenavalli! The status has been updated to "in progress" and is ready for you.

The Readme for dev-v2 has also been updated to include a link to the recording of the contributor's call, which can help provide additional guidance. Worth watching if you were unable to attend or have not yet seen it:
https://github.com/pnp/pnpjs/blob/dev-v2/README.md

Thank you again!

Hi @RamPrasadMeenavalli...Happy Friday! Hope your week has been going well. :)

We wanted to check-in and see how you are going with the current item and if you needed any help or had any questions?

We are aiming for a Release Candidate Beta by the end of September and wanted to follow up with the issues which are "In progress" to see how things are going.

Thank you so much again for helping out and looking forward to hearing from you. :)

Hi @PopWarner ,
Thank you for reaching out. I am working on this module, and should be able to provide some update by 1st week of Sep.

Great...Thank you @RamPrasadMeenavalli for the update! 馃憤

@juliemturner @simonagren @PopWarner, @patrick-rodgers
Submitted a PR for this module.

@RamPrasadMeenavalli, excellent! Thank you again!

Was this page helpful?
0 / 5 - 0 ratings