Pm: Constantinople Progress Tracker

[Souptacular]

This issue is meant to track the progress of client implementation and tests of the EIPs for the upcoming Constantinople hard fork.

Migrated to https://github.com/ethereum/pm/wiki/Constantinople-Progress-Tracker

Test Cases Spreadsheet

[carver]

Trinity Constantinople Milestone: https://github.com/ethereum/py-evm/milestone/2

[5chdn]

Parity Ethereum:

• EIP-1052 :white_check_mark: Yes https://github.com/paritytech/parity-ethereum/pull/9234
• EIP-1087 :exclamation: needs discussion https://github.com/paritytech/parity-ethereum/issues/8427#issuecomment-408782377

Did we decide to drop EIP-210? https://github.com/paritytech/parity-ethereum/pull/5505

[jbaylina]

Is EIP-1108 and EIP-1109 going to be included in Constantinople ?

[axic]

Progress tracker for ethereumjs: https://github.com/ethereumjs/ethereumjs-vm/issues/322

[ayrat555]

Mana progress: https://github.com/poanetwork/mana/issues/307

[pipermerriam]

Trinity

• EIP145 In progress
  
  
  
  • https://github.com/ethereum/py-evm/pull/1112 (merged)
  
  
  • https://github.com/ethereum/py-evm/pull/1134 (under review)
  
  

[pipermerriam]

Trinity: Here is the issue link for EIP1052

https://github.com/ethereum/py-evm/issues/719

[mkalinin]

EthereumJ: https://github.com/ethereum/ethereumj/issues/1149

[cburgdorf]

@Souptacular you can check EIP 145 for Trinity. It's implemented in https://github.com/ethereum/py-evm/pull/1134 and https://github.com/ethereum/py-evm/pull/1112 which are both merged in latest master

[cburgdorf]

@Souptacular and EIP1052 landed in Trinity as well https://github.com/ethereum/py-evm/pull/1147

[Souptacular]

Updated!

[holgerd77]

Can we eventually add progress on the test cases written in https://github.com/ethereum/tests to the progress tracker, maybe with the number of implemented/merged test cases on the column for an EIP? @winsvega?

Have absolutely no overview on the current state there.

In this context I just rediscovered this test cases collection spreadsheet for Metropolis, is this still updated/cared for or is there an alternative collection like this existing?

[winsvega]

yes. that google list is tracking new tests since before Metropolis. It is being updated.

[holgerd77]

@winsvega Ah great, would be really good if you guys can keep the doc as up-to-date as possible and also make it clear which tests are implemented and where to find the implementation (like being done in the RETURN CODES sheet e.g.). This really helps us a lot on the implementation side!

[chfast]

cpp-ethereum / EXTCODEHASH implemented.

[cburgdorf]

We implemented CREATE2 in Trinity. I will add that in contrast to the other new opcodes though, this one hasn't received much testing yet

https://github.com/ethereum/py-evm/pull/1186

[zilm13]

EthereumJ/Harmony:
EIP 145: Bitwise shifting instructions in EVM implemented
EIP 1052: EXTCODEHASH Opcode implemented
everything else in progress

[chfast]

Aleth / EIP 1283 done: https://github.com/ethereum/aleth/pull/5231

[5chdn]

Parity Ethereum / EIP-1234 _in progress_ https://github.com/paritytech/parity-ethereum/pull/9187

[lrettig]

Added EIP-1234 to the tracker

[gumb0]

Aleth / EIP-1234 done https://github.com/ethereum/aleth/pull/5247

[nateawelch]

Can the links to 145/1014 be updated to point to their respective eips.ethereum.org page? 1014 points to the pull request, which makes it difficult for people unfamiliar with git to read it.

[5chdn]

Parity Ethereum merged EIP-1283 https://github.com/paritytech/parity-ethereum/pull/9319

Parity Ethereum PR for EIP-1234 is https://github.com/paritytech/parity-ethereum/pull/9480 now (merged)

Parity Ethereum is feature-complete. https://github.com/paritytech/parity-ethereum/pull/9505

[ayrat555]

Mana implemented EIP-145 https://github.com/poanetwork/mana/pull/417

[ghost]

geth EIP-1234 in progress https://github.com/ethereum/go-ethereum/pull/17657

[ayrat555]

Mana EIP-1052 done https://github.com/poanetwork/mana/pull/420

[Souptacular]

@flygoing Done!

Chart updated.

[ytrezq]

@Souptacular : what about ᴇɪᴘ86 which was planned for Metropolis ?

[ghost]

@Souptacular I think the link is broken for geth - EIP 1283

It should be https://github.com/ethereum/go-ethereum/pull/17383

[mkalinin]

EthereumJ EIP-1283 PR merged, https://github.com/ethereum/ethereumj/pull/1173

[karalabe]

Ice age delay merged on Geth https://github.com/ethereum/go-ethereum/pull/17675

[tkstanczak]

EIP 145: Bitwise shifting instructions in EVM is done and tested in Nethermind, planning to work on all the remaining ones this week

[tkstanczak]

EIP-1052 is done and tested in Nethermind

[tkstanczak]

Nethermind meta here: https://github.com/tkstanczak/nethermind/issues/93

[ayrat555]

Mana / EIP-1014 done https://github.com/poanetwork/mana/pull/426

[tkstanczak]

Nethermind EIP-1014 done

[tkstanczak]

Nethermind EIP-1234 done

[tkstanczak]

Nethermind EIP-1283 done

[tkstanczak]

Nethermind all done, I will run available blockchain tests from ethereum/tests tomorrow to see if everything is fine.

[tkstanczak]

Do we expect an ethereum/test branch for Constantinople? Noticed that develop branch has incorrect mix hashes, block rewards and stExtCodeHash tests missing. Does anyone have an info on the golden source of tests for Constantinople?

[winsvega]

incorrect mixhashes are due to this change:
https://github.com/ethereum/tests/issues/480

stExtCodeHash are not ready.
The Constantinople tests are marked by Constantinople section in tests itself. no need to create separate branch.

[zilm13]

EthereumJ/Harmony
Implemented:
EIP-1014
EIP-1283
EIP-1234
So everything is done for us, but as Github tests are not final, we are following it and testing how do we pass all new tests. It's continuous task and some bugs in our EIP implementations could appear.

Our tracker: https://github.com/ethereum/ethereumj/issues/1149

[ayrat555]

Mana / EIP-1283 done https://github.com/poanetwork/mana/pull/433

[karalabe]

Net sstore also merged on Geth https://github.com/ethereum/go-ethereum/pull/17383 . We were waiting with this for a release, but postponed v1.8.16 for next Monday, so figured we can push it out now.

[cburgdorf]

@Souptacular EIP 1234 just landed in Trinity https://github.com/ethereum/py-evm/pull/1303

[ayrat555]

EIP 1234 is merged in Mana https://github.com/poanetwork/mana/pull/447

[mkalinin]

EthereumJ. CREATE2 gas price update merged https://github.com/ethereum/ethereumj/pull/1204

[5chdn]

Parity Ethereum is ready to hardfork Ropsten w/ updated CREATE2 spec.

• https://github.com/paritytech/parity-ethereum/pull/9562
• https://github.com/paritytech/parity-ethereum/pull/9688
• https://github.com/paritytech/parity-ethereum/pull/9694
• https://github.com/paritytech/parity-ethereum/pull/9704

Preparing a compatible release now.

[ajsutton]

I'm happy to add that Pantheon has added support for all the Constantinople EIPs, including the updated CREATE2 spec.

[holgerd77]

EthereumJS:
CREATE2 (EIP-1014):
Unknown -> WIP (https://github.com/ethereumjs/ethereumjs-vm/pull/329)
SSTORE (EIP-1283):
Unknown -> now merged, ready (https://github.com/ethereumjs/ethereumjs-vm/pull/367)
Difficulty Bomb (EIP-1234):
Unknown -> WIP (https://github.com/ethereumjs/ethereumjs-block/pull/54)

[cburgdorf]

@Souptacular trinity just landed support for EIP-1283 https://github.com/ethereum/py-evm/pull/1410
Only thing left for us is to ensure we run all state tests for constantinople (which should land within the next days)

[dwightguth]

KEVM now supports constantinople: https://github.com/kframework/evm-semantics/pull/267

We will continue to test with more up-to-date versions of the test suite up until launch.

[ehildenb]

@Souptacular can you add KEVM to the client matrix in the first comment?

@dwightguth I think the first 4 columns we are a "Yes" on, but the last column we are an N/A on because we don't do any fork-choice/block-validation, only execution.

[shemnon]

Pantheon's github repo is now open and can be linked: https://github.com/PegaSysEng/pantheon

[InoMurko]

Since joined forces have been announced to work on Mana, exthereum should be removed.

[holgerd77]

EthereumJS: CREATE2 (EIP-1014), Difficulty bomb (EIP-1234): WIP -> Complete

[holgerd77]

Associated PRs:
CREATE2: https://github.com/ethereumjs/ethereumjs-vm/pull/329
Difficulty bomb: https://github.com/ethereumjs/ethereumjs-block/pull/54

[winsvega]

Could we extend the head post with following links to the test cases lists?
this links also contain links to the actual tests in the repo.

1) extcodehash cases: https://docs.google.com/spreadsheets/d/1xat7UI8GtB4ZGVdlK5_XQSHJZaMThi4SrlcL8XMZb5Q/edit?pli=1#gid=1811198384

2) bitshift cases:
https://docs.google.com/spreadsheets/d/1xat7UI8GtB4ZGVdlK5_XQSHJZaMThi4SrlcL8XMZb5Q/edit?pli=1#gid=2010405893

3) sstore cases:
https://docs.google.com/spreadsheets/d/1xat7UI8GtB4ZGVdlK5_XQSHJZaMThi4SrlcL8XMZb5Q/edit?pli=1#gid=878289780

4) create2 cases;
https://docs.google.com/spreadsheets/d/1xat7UI8GtB4ZGVdlK5_XQSHJZaMThi4SrlcL8XMZb5Q/edit?pli=1#gid=1872446916

5) difficulty change and reward change related:
https://docs.google.com/spreadsheets/d/1xat7UI8GtB4ZGVdlK5_XQSHJZaMThi4SrlcL8XMZb5Q/edit?pli=1#gid=1197466216

[5chdn]

Might make sense to put this in the wiki, so everyone can edit it. Maybe directly here in the repository? Need a hand @lrettig @Souptacular ?

[holgerd77]

@5chdn This is the main working sheet for @winsvega to organize test creation, I think the wiki here wouldn't be the right place for this, let's please just stick to linking this as originally suggested.

[5chdn]

Yeah, I'm just talking about "extending the head" post, it would be easier to have the ability to just edit a wiki somewhere instead of waiting for one person to do it. I'm not talking about adding the content of the links to the wiki.

[lrettig]

I migrated the progress tracker to a wiki page at https://github.com/ethereum/pm/wiki/Constantinople-Progress-Tracker but it looks like it may still not have global edit access. @Souptacular will have to fix that.

[Souptacular]

@lrettig I set up the proper permissions now.

[5chdn]

Amazing. Updated!

[holgerd77]

Our EthereumJS VM release v2.5.0 with full Constantinople support (and other goodies like consensus conformity and a revamped state manager) is finally out.

[sea51930]

63

[5chdn]

Moving the meta-EIP 1013 to final https://github.com/ethereum/EIPs/pull/1642

I think this tracker can be closed now.

[lrettig]

Closing