Plyr: Wrong aspect ratio and height in version 3.5.7 and above

Created on 19 Apr 2020  路  7Comments  路  Source: sampotts/plyr

Expected behaviour

The player doesnt overlap and has the right aspect ration and height. This is the behavior of version 3.5.6 and below.
Screenshot_233

Actual behaviour

The player completely pushes all othe elements out of the area and overlaps because the aspect ration and height are wrong. This is the behavior of version 3.5.7 to 3.5.10.
Screenshot_232

Environment

  • Browser: I used Opera but the bug is also in Chrome, Firefox and Edge
  • Version: 67.0.3575.137
  • Operating System: Windows
  • Version: 10

Link to where the bug is happening

Codepen of buggy version 3.5.10

Bug In Development Replicated

Most helpful comment

I found out how to fix it: https://github.com/sampotts/plyr/blob/ef85cb6195dc07627bd4fd357723c6ee96033ed9/src/sass/base.scss#L15
Removing this line or using height: unset; solves the problem!
You can try this out on the codepen mentioned above. Just add

.plyr 
{
    height: unset;
}

into the css section and the aspect ratio goes back to normal

All 7 comments

Thanks. I had noticed this myself locally but couldn't trace the cause. Your info version allowed me to track it down to this:
https://github.com/sampotts/plyr/pull/1679/files#diff-5e4f0b0fceaec73161f6a713ede69511L19

I'll try and get a new version out ASAP with the fix 馃憤

I am glad i was able to help you! And wow that was a pretty fast bug diagnosis! 馃憤

This should be resolved in the latest version 馃憤

The issue is still there in 3.6.1
Codepen

I found out how to fix it: https://github.com/sampotts/plyr/blob/ef85cb6195dc07627bd4fd357723c6ee96033ed9/src/sass/base.scss#L15
Removing this line or using height: unset; solves the problem!
You can try this out on the codepen mentioned above. Just add

.plyr 
{
    height: unset;
}

into the css section and the aspect ratio goes back to normal

@SnGmng Doesn't seem to work for me. Will this be fixed in plyr?

Getting this issue too on 3.6.2 and it seems to be a height: 100% issue. See image below.

image

I had to force it to height: auto !important; for the ratio to be normal and have the regular aspect of older versions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

muuvmuuv picture muuvmuuv  路  3Comments

elliottcoe picture elliottcoe  路  4Comments

ahmadshc picture ahmadshc  路  3Comments

Skwai picture Skwai  路  4Comments

sparkktv picture sparkktv  路  4Comments