Plyr: Dailymotion Support

[swiretvweb]

[abazeed]

You have the best open source player yet. Adding support to @dailymotion will push you ahead away from other players, please put more efforts on this.

[kevinfaguiar]

+1 for Dailymotion support.

[adeeb1]

Any updates here? We'd love Dailymotion support.

[akuma06]

I'm planning to add dailymotion support for my own use, should I make a PR @friday ?

[friday]

@akuma06 It's up to @sampotts. There were architectural reasons we wanted that to be moved to plug in support. Maintaining providers is hugely problematic. I don't think that has changed, but I'm no longer contributing to plyr's development.

[akuma06]

Thanks for the reply! So I have pushed a new branch to my fork of the develop branch implementing DailyMotion (https://github.com/akuma06/plyr/tree/dailymotion). I have tested it locally and I will use it for my own app. It comes down now to @sampotts wether he wants me to PR it now or wants to wait for his plugin system. :)

[adeeb1]

Thanks @akuma06, I would love for your work to be in PR. We are starting to integrate Plyr in our application, and we would want immediate Dailymotion support. +1 from me

[abazeed]

Hello @sampotts, are you planning to pull @akuma06 's changes? We are patiently waiting to have this feature live and hope to push this a step forward at the soonest. Many thanks.

[adeeb1]

I wanted to chime in here again to thank @akuma06 for the wonderful work! The Dailymotion support works perfectly, and I'm happily using it in my app through my own fork of this repo. It would be wonderful to have it merged into the official repo.

[abazeed]

Yes @adeeb1, It would be wonderful to have it merged into the official repo 🥺

[abazeed]

@sampotts congrats on the new release. wasn't there any chance to consider this in this new release? or any upcoming ones, please?

[sampotts]

Happy to take a look at a PR for it...

[abazeed]

Happy to take a look at a PR for it...

Thank you @sampotts!
@akuma06, could you please PR your changes?

[akuma06]

I don't mind doing the pr for it after I've checked if there are any changes with the new release. I didn't do it before since I thought @sampotts wanted to prioritize a plugin system before adding any new platform to the code base.
Will submit a pr this week :).