Plyr: If we right click on video player then 'Show controls' option is visible, if we select that then basic HTML5 player controls along with custom player controls are visible

Created on 18 May 2016  路  5Comments  路  Source: sampotts/plyr

Steps to Reproduce

  1. Hit the URL : https://plyr.io/#video
  2. Right click on the player
  3. Observe that options like : 'Loop', 'Show controls' etc are visible on player
  4. Now select the 'Show controls' option
  5. Observe that : Basic HTML5 player controls along with custom player controls are visible for video player

Expected Results :

  1. 'Show controls' option should not be visible when we right click on player
  2. Only custom player controls should be visible on video player

Actual Results :
If we right click on video player then 'Show controls' option is visible, if we select that then basic HTML5 player controls along with custom player controls are visible

Notes :
See the attached screen shot :
two_player_controls_18may

Most helpful comment

There's something about killing the context menu that doesn't feel good to me. There are other options in there that user may find useful. I'll look into using shadow DOM selectors to hide the default controls.

All 5 comments

add this to your video tag , oncontextmenu="return false;"

There's something about killing the context menu that doesn't feel good to me. There are other options in there that user may find useful. I'll look into using shadow DOM selectors to hide the default controls.

I added an option to hide the context menu using @johnyeye 's code. Thanks for that 馃憤

That worked for me too, Thanks @johnyeye

@accunity-arpit It's built in as an option now - see my comment above yours from last year 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tomByrer picture tomByrer  路  3Comments

sparkktv picture sparkktv  路  4Comments

onigetoc picture onigetoc  路  3Comments

ahmadshc picture ahmadshc  路  3Comments

frumbert picture frumbert  路  3Comments