Plugin.video.themoviedb.helper: [Log Spam] Trying to load setting definitions from old format...

[tjamieg]

2020-01-24 15:21:52.013 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: loading setting definitions
2020-01-24 15:21:52.014 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: trying to load setting definitions from old format...
2020-01-24 15:21:52.017 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: loading setting values
2020-01-24 15:21:52.018 T:26452   DEBUG: CSettingsManager: requested setting (trakt_token) was not found.
2020-01-24 15:21:52.018 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: failed to find definition for setting trakt_token. Creating a setting on-the-fly...
2020-01-24 15:21:52.023 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: loading setting definitions
2020-01-24 15:21:52.023 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: trying to load setting definitions from old format...
2020-01-24 15:21:52.027 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: loading setting values
2020-01-24 15:21:52.028 T:26452   DEBUG: CSettingsManager: requested setting (trakt_token) was not found.
2020-01-24 15:21:52.028 T:26452   DEBUG: CAddonSettings[plugin.video.themoviedb.helper]: failed to find definition for setting trakt_token. Creating a setting on-the-fly...
2020-01-24 15:21:52.030 T:26452  NOTICE: [plugin.video.themoviedb.helper]
                                            Error: attribute of type 'NoneType' is not callable
2020-01-24 15:21:52.059 T:26452  NOTICE: Previous line repeats 8 times.

[jurialmunkey]

Kodi Version?
OS?
Platform?

I don't get these errors on 18.5 on Windows or LibreELEC.

[jurialmunkey]

@tjamieg can you test latest version (v2.2.36)? This issue is a known kodi bug that will be fixed in Matrix - but I'm hoping that this change I've made might reduce the log spam a bit.

[tjamieg]

Kodi Version: 18.5
OS: Android (ARMV7A)
Device: Amazon Fire TV Stick 4K

Understood, will test latest version and get back to you.

[drinfernoo]

@jurialmunkey, for more information, what is the "old" format, and how can we make sure we're using compatible formats for settings in the future?

[tjamieg]

@drinfernoo I was wondering if it could have been referring to Python 2.7 and 3.0.

@jurialmunkey nixgates came across the same thing here and there was also this on the XBMC github.

[jurialmunkey]

@jurialmunkey, for more information, what is the "old" format, and how can we make sure we're using compatible formats for settings in the future?

In Matrix, the format of Addon settings.xml has been changed to match Kodi's inbuilt setting format. The change allows for having settings "levels" (e.g. Basic, Advanced, Expert) just like Kodi settings (e.g. Interface settings etc.).

In Leia, there was an attempt to transition to this new format but it brought some issues that weren't discovered until after it was implemented and a fix wasn't able to be made in a point release.

There's info on the new format here:
https://kodi.wiki/view/Add-on_settings_conversion

[tjamieg]

@jurialmunkey I just tested the latest version (v2.2.36) and the log is still very spammy.

[jurialmunkey]

@jurialmunkey I just tested the latest version (v2.2.36) and the log is still very spammy.

Yeah, it was a bit of a long shot. I'll have a read around and see if I can find anything else out.

Can you get me your settings.xml from userdata/addon_data/plugin.video.themoviedb.helper/settings.xml ? Before posting be sure to remove your OMDb and Fanarttv keys from the file.

[drinfernoo]

@jurialmunkey I see! I'd never stumbled on that page, but always assumed it had to do with the change from [sg]etSetting(...) to [sg]et[Type]Setting(...)?

What happens in Leia if we start using that format?

[jurialmunkey]

@drinfernoo - I'm not sure, I've never tried the new format but it's not recommended if the addon is meant to be compatible for both Leia and Matrix. The issue is that other bugs have been introduced as a result of the code for the new format.

[drinfernoo]

Also @jurialmunkey, how the heck you do it, I dunno, but almost every single time I push to the repo, you make more updates within the hour 😅

[tjamieg]

@jurialmunkey I just tested the latest version (v2.2.36) and the log is still very spammy.

Yeah, it was a bit of a long shot. I'll have a read around and see if I can find anything else out.

Can you get me your settings.xml from userdata/addon_data/plugin.video.themoviedb.helper/settings.xml ? Before posting be sure to remove your OMDb and Fanarttv keys from the file.

Here you go:
settings.xml

[jurialmunkey]

Thanks. I'm a bit stumped though, as there doesn't look to be anything wrong here. Same format as on my systems but I don't get this log spam. I wish I had an Android device to test as it seems limited to that platform.

I'll ask around the Kodi team to see if anyone else has any insight and I'll get back to you.

[jurialmunkey]

@tjamieg - Can you try closing Kodi, delete the settings.xml file from the addon_data folder, restart Kodi, then reauthorise Trakt and see if you still get the log spam.

The log spam is apparently due to storing a setting which is not available in settings dialog. I've added a hidden setting for trakt_token to the settings dialog in the previous version in the hope that it will stop the errors. The only thing I can think of why you are still getting the log spam is because kodi needs to recreate the settings.xml

If this doesn't help, then it's unlikely there is anything else I can do about it.

[drinfernoo]

@jurialmunkey That causes the "creating a setting on the fly" message, but the one about the old format 🙃

[jurialmunkey]

@drinfernoo - Are you getting this log spam too? Can you test latest version and see if that fixes it? I wonder if making the setting visible will help...

[tjamieg]

@jurialmunkey Hey guys, tried the latest version (2.2.40) and also tried deleting settings.xml and reauth-ing Trakt... but the issue STILL persists.

Also tried it on a build with some other add-ons, and after checking the debug log I realise that this issue is not just native to TMDb Helper; @drinfernoo's OpenWizard has it and so does @nixgates' Seren.

[drinfernoo]

@tjamieg It's because all of those add-ons use the "old" settings format.

[jurialmunkey]

Closing this issue as I don't think there is a solution until Matrix.