Plugin-php: Chained method arguments split up unnecessarily

[hackel]

@prettier/plugin-php v0.14.3
Playground link

Input:

<?php

$query
    ->selectRaw('count(*) as `count`, date_format(`created_at`, "%Y-%m-01") as `date`')
    ->from('quote_searches')
    ->where('account_id', $accountId)
    ->where('created_at', '>=', Carbon::now()->startOfMonth()->subMonths($months))
    ->groupBy('date');

Output:

<?php

$query
    ->selectRaw('count(*) as `count`, date_format(`created_at`, "%Y-%m-01") as `date`')
    ->from('quote_searches')
    ->where('account_id', $accountId)
    ->where(
        'created_at',
        '>=',
        Carbon::now()
            ->startOfMonth()
            ->subMonths($months),
    )
    ->groupBy('date');

I'm specifically referring to the second where call. Prettier leaves this alone, so I assume it must be caused by the php plugin. It's behaving as if the print-width is much less. (I use 120, but this even fits in 80.)

Prettier 2.1.2
Playground link

--arrow-parens avoid
--parser babel
--print-width 120
--single-quote
--tab-width 4
--trailing-comma all

Input:

$query
    .selectRaw('count(*) as `count`, date_format(`created_at`, "%Y-%m-01") as `date`')
    .from('quote_searches')
    .where('account_id', $accountId)
    .where('created_at', '>=', Carbon.now().startOfMonth().subMonths($months))
    .groupBy('date');

Output:

$query
    .selectRaw('count(*) as `count`, date_format(`created_at`, "%Y-%m-01") as `date`')
    .from('quote_searches')
    .where('account_id', $accountId)
    .where('created_at', '>=', Carbon.now().startOfMonth().subMonths($months))
    .groupBy('date');

[Eldair]

Same in latest version. Looks bad, especially in IF statements.

[czosel]

I totally agree. Potentially, we could check how Prettier for JS handles this and port some of the logic to the plugin. cc @evilebottnawi

[alexander-akait]

Good idea