Plugin-php: Removes parentheses when "and" is combined with ternary expression

[ZeeCoder]

@prettier/plugin-php v0.11.2
Playground link

Input:

<?php

$someVeryVeryLongValue1 = 1;
$someVeryVeryLongValue2 = 2;

var_dump(
    ($someVeryVeryLongValue1 and $someVeryVeryLongValue2)
        ? 'true value'
        : 'false value'
);

Output:

<?php

$someVeryVeryLongValue1 = 1;
$someVeryVeryLongValue2 = 2;

var_dump(
    $someVeryVeryLongValue1 and $someVeryVeryLongValue2
        ? 'true value'
        : 'false value'
);

The above two are not equal in execution.
It would be fine to do this for the && operator, as that has a higher precedence than the ternary, but the same is not true for "and":
https://www.php.net/manual/en/language.operators.precedence.php

[alexander-akait]

PR welcome

[ZeeCoder]

Any starting points you would recommend?

[alexander-akait]

Here logic for parens https://github.com/prettier/plugin-php/blob/master/src/needs-parens.js

[ZeeCoder]

@czosel @evilebottnawi this is still an issue in v12.

@prettier/plugin-php v0.12.0
Playground link

[czosel]

Strange. I’ll try to look into this in the coming days.

[czosel]

Ah, the answer is simple: The fix is not part of the 0.12.0 release - it should be working in master though.

[ZeeCoder]

All right, guess I'll just wait for the next release and re-test then.