Plots2: Disable Edit Button for non-author comment replies

[daemon1024]

Currently, any non-author of the comment reply sees the edit and delete button in the comment reply card.

After trying to publish the changes you come across

Please describe the desired behavior.

Like how it's in normal comments, there shouldn't be any edit or delete buttons in the comment replies as well for non authors

[daemon1024]

This can be converted into a FTO if it's a valid input :D @publiclab/plots2-reviewers @publiclab/comment-maintainers

[Elukoye]

@daemon1024 can I work on this as a non-FTO?

[daemon1024]

Hi @Elukoye, Sure 👍🏼

You will probably need to dabble into some React for this.
The components are here - https://github.com/publiclab/plots2/tree/main/app/javascript/components

Feel free to ping me here in case of any blockers 😃

Thank You 😄

[Elukoye]

@daemon1024 ,ok will get to it. Will ping you incase I meet a roadblock.🙂🚀

[noi5e]

Actually @daemon1024 @Elukoye, this is not occurring in /app/javascript/components. plots2 currently has two different versions of the comment system, one written in Rails, and the other written in React.

This bug is occurring in the Rails comment system. See here to start:
https://github.com/publiclab/plots2/blob/e646cfd248e46fe9cf11a2eb7860bbf29f949b7d/app/controllers/comment_controller.rb#L100-L103

@Elukoye, I've spent a lot of time working on the comment system, let me know if you get stuck!

[daemon1024]

@noi5e Thank You for clarifying. ☺️

My bad, I just assumed it was the new system since I saw the recent migrations. 😅

[Elukoye]

@noi5e ,thanks so much for this,🙂. Will reach out a.s.ap if I encounter a blocker

[Elukoye]

@noi5e ,I think the backend is working fine. So I think I will fix the UI to remove the edit and delete buttons. I think that's why @daemon1024 said it was react. @noi5e does this rails comment system use Bootstrap or React to render the comment card ?

[noi5e]

@Elukoye This error is occurring in the Rails commenting system. Rails renders a front-end template (a "view"), which you can find here:
https://github.com/publiclab/plots2/blob/e646cfd248e46fe9cf11a2eb7860bbf29f949b7d/app/views/notes/_comment.html.erb#L55-L70

[Elukoye]

Thanks @noi5e

[Elukoye]

@noi5e, could you assist me with this 🙂 ?
I think the comment's controller logic is ok.
I checked this file https://github.com/publiclab/plots2/blob/e646cfd248e46fe9cf11a2eb7860bbf29f949b7/app/views/comments/_comments.html.erb
and I think it should be modified to render comment partials for current users that are neither moderators, then render their partials without the flag as spam action, edit button and delete icon.
From the comments partial, I can only spot the flag icon and envelop icon.
What do you think?

[TildaDares]

@Elukoye I think you should be looking at https://github.com/publiclab/plots2/blob/e646cfd248e46fe9cf11a2eb7860bbf29f949b7d/app/views/notes/_comment.html.erb#L55-L70 as @noi5e said

[Elukoye]

@TildaDares ,thanks ...will keep working on it.

[Priyaraj17]

@Elukoye are you currently working on this issue? May I take a look into this?

[Elukoye]

@Priyaraj17 ,hi 🙂....yes am still working on this ,so far have been able to check for this error in the development environment and it seems as though the delete and edit button don't show there ,I had a problem with redis,managed to fix that ,so now I want to test it gain.

[Priyaraj17]

Okay, let me know if you need any help. Thanks!