Plots2: Content interferes with toolbar functions in editor

Created on 4 Apr 2021  路  12Comments  路  Source: publiclab/plots2

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

The writeup content of the post gets mixed up with the editor toolbar when scrolling or viewing content in general while making a post.

FC586C05-ABF2-4D59-A9CB-1655D4D4A9DA_1_201_a

Please show us where to look

https://publiclab.org/

What's your PublicLab.org username?

waridrox

Browser, version, and operating system

Chrome v89

Possible solution could be to hide the transparency of the buttons and make them like the first half of the toolbar section so as to maintain the consistency.

Steps to reproduce the error

Here's how one can reproduce the error -

  1. Click on share your work button to create a new post.
  2. Move to content section and add a few paragraphs.
  3. Scroll the page by placing the cursor outside the content section.
  4. Witness the error

https://user-images.githubusercontent.com/58583793/113518246-b347cd80-95a2-11eb-9e40-92ad4c35010c.mp4

bug

Most helpful comment

Hey, you just need to add the issue number in the PR template.

All 12 comments

Interestingly, I'm not able to reproduce the bug locally 馃 Can someone pls confirm -

https://user-images.githubusercontent.com/58583793/113585901-77684300-964a-11eb-966f-5ac0fdbff484.mp4

Can I work on this?

@TildaDares sure 馃槃, go for it! 馃殌

@waridox I was able to reproduce the error locally. I think a possible fix would be to make these buttons have an opaque background.

Before

Screenshot 2021-04-08 at 15 34 31

After

Screenshot 2021-04-08 at 15 38 04

What do you think?

Yes, @TildaDares you're thinking in the right direction! We don't require transparency on those buttons with the content.

This can be accomplished by adding this rule:

.btn-light {
    background-color: white;
}

However, it should be noted that the Tags button is lacking the .btn-light class for whatever reason so more investigation is required.

@eightballocto The Toolbar already has a btn-light class but btn-outline-secondary is overriding it. Also I can't find this page in my local environment, can you please show me where it is?

Just to be sure these are the tags you're referring to.

image

@eightballocto The Toolbar already has a btn-light class but btn-outline-secondary is overriding it. Also I can't find this page in my local environment, can you please show me where it is?

image
using Inspect Element in my developer environment. It seems like these buttons are dynamically generated or from elsewhere. The "Tags" button I was referring to is in the toolbar, not the text field.

Edit/Addendum: I was also unable to find these elements in my local environment, hence my suspicion of it being in a separate repository or dynamically generated (which wouldn't make much sense, if you ask me)

Hi all, @eightballocto is right and there's a different repository https://github.com/publiclab/PublicLab.Editor dedicated to the editor functionality and I recommend to take a look at https://github.com/publiclab/PublicLab.Editor/issues/664 to anyone who is trying to come up with the fix. Thanks :)

@waridox How do I link this issue to my PR?

Hey, you just need to add the issue number in the PR template.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gautamig54 picture gautamig54  路  84Comments

SidharthBansal picture SidharthBansal  路  116Comments

jywarren picture jywarren  路  154Comments

cesswairimu picture cesswairimu  路  119Comments

grvsachdeva picture grvsachdeva  路  86Comments