Plots2: camelCase comment_expand.js filename

Created on 7 Feb 2021  ยท  5Comments  ยท  Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you ๐Ÿ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

๐Ÿค” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

โ“ Why are we doing this?

See Issue #9140 for more information!

๐Ÿ“‹ Step by Step

  • [ ] ๐Ÿ™‹ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] ๐Ÿ“ Update these files below:

See this page for some help in taking your first steps!

Below are some "diffs" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add for each file:

/app/views/admin/assets.html.erb

+ <%= javascript_include_tag  'commentExpand' %>
- <%= javascript_include_tag  'comment_expand' %>

/app/views/questions/show.html.erb

+ <%= javascript_include_tag('commentExpand') %>
- <%= javascript_include_tag('comment_expand') %>

/config/initializers/assets.rb:

+ 'commentExpand.js', 
-  'comment_expand.js',

/spec/javascripts/comment_spec.js

+ //= require commentExpand
- //= require comment_expand

/app/assets/javascripts:

+ commentExpand.js
- comment_expand.js
  • [ ] ๐Ÿ’พ Commit your changes

  • [ ] ๐Ÿ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] ๐Ÿ Done Ask in comments for a review :)

Please keep us updated

๐Ÿ’ฌโฐ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

๐Ÿ”—- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

๐Ÿ‘ฅ- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

๐Ÿค”โ“ Questions?

Leave a comment below!

first-timers-only

Most helpful comment

@noi5e Hi I would like to work on this issue

All 5 comments

Claimed!

@iamayushdas I'm closing your PR and freeing up the issue for someone else to work on. Let me know if you want to continue working on this, or would like some help! :)

@noi5e Hi I would like to work on this issue

@manchere Great, go ahead!

@noi5e thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gautamig54 picture gautamig54  ยท  84Comments

SidharthBansal picture SidharthBansal  ยท  87Comments

grvsachdeva picture grvsachdeva  ยท  196Comments

jywarren picture jywarren  ยท  81Comments

CleverFool77 picture CleverFool77  ยท  73Comments