Plots2: Remove map marker button from tags input

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/tag/_form.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Here, we'll be removing the map marker button as shown in this screenshot:

The button appears in a form on the sidebar of pages like https://publiclab.org/notes/warren/09-14-2020/congratulations-to-our-outreachy-and-gsoc-2020-fellows (login required to see it)

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -8,10 +8,7 @@
         <span class="input-group-text"><i class="fa fa-tags"></i></span>
       </div>
       <input aria-label="Enter tag name" autocomplete="off" class="tag-input form-control" name="name" type="text" placeholder="<%= translation('tag._tagging.enter_tags') %>" data-provide="typeahead" />
-      <div class="input-group-append">
-        <a class="btn btn-outline-secondary blurred-location-input" rel="tooltip" title="Link with a location" style="border-color:#ccc;">
-          <i class="fa fa-map-marker"></i>
-        </a>
+      <div class="input-group-append">        
         <%= render partial: 'tag/advanced_tagging' %>
       </div>
     </div>

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

• If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.
• If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

1. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

Part of #6593 !

[shrena-patel]

I would like to take this one please :)

[jywarren]

That'd be great, please go ahead and be sure to link to your pull request as soon as you create one! Thanks!

[shrena-patel]

Thanks, will do.

Just to check, I have forked the repo and edited the file in github rather than cloning the repo and creating a branch for the issue - is that okay? I just followed what the instructions said. Also, are the tests the checklist refers to just the green 'able to merge' text? This is my first open source contribution in case you can't tell! Thanks :)

[shrena-patel]

Link to pull request for review: https://github.com/publiclab/plots2/pull/8627

[jywarren]

Yes, that's fine, and thanks for the link, i'll hopefully review tomorrow! You should be able to start up the project with your changes by clicking the "Gitpod" button, too, in your PR! Great work!

[AnneThor]

Hi @jywarren! I was directed to this issue as a good first-timers issue (I'm an outreachy applicant), but it looks like it is already resolved? Do you have anything else available? Thanks!!