Plots2: Wrong text input gets selected while using toolbar on comments

Created on 7 Oct 2020  路  5Comments  路  Source: publiclab/plots2

While trying to add new comment when any of the option is choosen from toolbar the changes are displayed in different text input.

ezgif com-video-to-gif (6)

where to look

https://publiclab.org/questions/Cogreg/09-20-2020/how-do-i-test-home-made-fertilizer

bug

Most helpful comment

Hi @sagarpreet-chadha - just noting that the "spin out new library" would happen /after/ most of the fixes and refinements in the Comment project - it'll be a stretch goal. Thanks!

This is a great catch @urvashigupta7 and I think we'll have to do a couple things. We should identify all the various types of comment boxes -- i made a list below -- and ensure that a proper unique CSS id is assigned for all of them, in a standard way, and protect this with tests --

* comment
* reply to comment
* comment just posted (form inserted via AJAX)
* reply to comment just posted
* editing existing comments
* editing comments just posted
* editing comment replies
* editing comment replies just posted

This is a major part of the Comment project for Outreachy!

All 5 comments

Correct!
Always the first comment editor is changed. This is because if do not have any id associated to each comment editor.

Hi @Sagarpreet . Outreachy applicant here. Can I take a look at this?

Hey @nibble0101 , yes we would like your help 馃憤
So this is a little big issue, you may want to break this down 馃槃
Also let鈥檚 wait for @jywarren approval before we start because we might want to spin off a separate library for comment editor and solving here may not be useful now.

Hi @sagarpreet-chadha - just noting that the "spin out new library" would happen /after/ most of the fixes and refinements in the Comment project - it'll be a stretch goal. Thanks!

This is a great catch @urvashigupta7 and I think we'll have to do a couple things. We should identify all the various types of comment boxes -- i made a list below -- and ensure that a proper unique CSS id is assigned for all of them, in a standard way, and protect this with tests --

* comment
* reply to comment
* comment just posted (form inserted via AJAX)
* reply to comment just posted
* editing existing comments
* editing comments just posted
* editing comment replies
* editing comment replies just posted

This is a major part of the Comment project for Outreachy!

Starting to work on this one! Just made a PR to add unique IDs to the toolbar buttons. After that, I think it will be a very similar fix to the image upload cross-wiring issues (linked above in this issue)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grvsachdeva picture grvsachdeva  路  86Comments

sagarpreet-chadha picture sagarpreet-chadha  路  72Comments

SidharthBansal picture SidharthBansal  路  100Comments

sagarpreet-chadha picture sagarpreet-chadha  路  152Comments

ebarry picture ebarry  路  73Comments