Plots2: Replace .count and .length in tag model with .size

[cesswairimu]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file https://github.com/publiclab/plots2/blob/main/app/models/tag.rb (press the little pen Icon) and edit the line as shown below.

• Replace all instances of .count and .length with .size

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

[Samasth]

@cesswairimu I am new here, can I please work on this issue?

[cesswairimu]

Hi @Samasth , this is assigned to someone...I have created another one for you...feel free to claim it #8211

[JubayerJoy]

Hi @cesswairimu, if anyone is not working on it, I want to take the job.

[cesswairimu]

Hi @JubayerJoy, it seems Samasth worked on another fto...Its all yours, you can go ahead. Thanks

[Hassanelashram]

Is this issue still open ? @cesswairimu
If yes I could do it.

[cesswairimu]

Hi @Hassanelashram , yeah its still open. We would love your help..go ahead. Thanks

[Hassanelashram]

Hi @Hassanelashram , yeah its still open. We would love your help..go ahead. Thanks

On it, thank you for the quick reply.
Quick Question, Do I need to also change the JS instances .length -> .size ? @cesswairimu

[cesswairimu]

Nope, just the ruby bit.

[Hassanelashram]

Nope, just the ruby bit.

Done, I also have a branch locally where I did the same thing all over the codebase because I misunderstood and thought that was what needed to be done.
If you need to change them all in the codebase later on let me know and i could make a PR with my changes.

[cesswairimu]

I am sure if there is a .size method in js. We are replacing the ruby queries with .size because its almost twice as fast than the .count

[sangu09]

Hey, I would like to work on this issue.

[cesswairimu]

Great :tada: , @sangu09, I will update on the PR the parts that will cause some errors. Thanks

[sangu09]

Thanks @cesswairimu for the help! I am still working on some failing Travis jobs by looking at the logs.

[sangu09]

@cesswairimu is there anything in the code coverage part that I need to take care of? The codecov reports suggests a decrease in code coverage.

[cesswairimu]

@sangu09 no, the since we are not adding any code we can ignore the codecov. I see travis failures are all fixed :tada: Thanks