Plots2: Add an underline to the "choose one" link in wiki page image upload form

Created on 21 Jul 2020 · 12Comments · Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the file app/views/editor/_editor.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -20,7 +20,7 @@
         <!-- http://stackoverflow.com/questions/11235206/twitter-bootstrap-form-file-element-upload-button -->
         <label class="" for="fileinput">
           <input id="fileinput" type="file" name="image[photo]" style="display:none;" />
-          <a class="d-none d-md-inline">choose one</a>
+          <a class="d-none d-md-inline text-underline">choose one</a>
           <span class="d-md-none">
             <i class="fa fa-upload"></i>
             <a>Upload image</a>

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.
If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Most helpful comment

I'll try this one

aakanchha01 on 21 Jul 2020

🎉2

All 12 comments

I'll try this one

aakanchha01 on 21 Jul 2020

🎉2

@jywarren I have created a pull request for this issue. Please review :)

aakanchha01 on 21 Jul 2020

I would like to take this one

Om-Vg on 23 Jul 2020

Hey @aakanchha01 , i think you have made PR in the forked repository which is like your local repository. You need to make PR against this publiclabs/plots2 repository. You can change the base branch of your PR by directly editing the PR and changing to publiclab/plots2.
Let us know if you need any help 🎉 💯

Hi @OmLakshmi , this issue is already taken up...can you try to claim other first timers issue. Let me know if you find one otherwise i will make one Thanks 😄 🎈

sagarpreet-chadha on 23 Jul 2020

@sagarpreet-chadha oh okay. I have created a new PR with base repo as publiclab/plots2. Please let me know if something with the new PR is still incorrect. Also, there was an option to edit the branch in the old PR but I couldn't find option to change base repo. Might be, I am missing something. Thanks for your help :)

aakanchha01 on 24 Jul 2020

Hello @sagarpreet-chadha I couldn't find any fto's that weren't claimed already.

Om-Vg on 24 Jul 2020

So is this assigned already or not? Tags say it's not assigned yet, but there are comments here.

Hunahpu23 on 2 Aug 2020

I'm interested if it's not assigned to anyone yet.

elpablitos on 4 Aug 2020

Hi @aakanchha01 - are you still available to work on this? If @aakanchha01 isn't or can't reply in the next couple days, we'd love to have someone else try to help out, thank you! You can simply start by mentioning that you've begun, and opening a pull request and linking to it. Thank you all!