Plots2: Profile picture can be updated without entering password but bio cant be added

Created on 30 Mar 2020  路  11Comments  路  Source: publiclab/plots2

Please describe the problem (or idea)

In the current scenario it is possible to update the profile picture in the edit profile without entering current password but bio can't be added without entering the current password.

So either updation should be allowed without entering current password for both profile picture and bio or it should not be allowed for anything without entering current password. Important for consistency across the app.

Gif

img1
img2

Please show us where to look

https://publiclab.org/ ...

Thank you!

bug

All 11 comments

@VladimirMikulic @jywarren can you kindly approve? Thanks :v:

I would leave it without a password, since it's not something sensitive like confirming an email, 2FA...

@VladimirMikulic so bio updation should be allowed without entering current password right?

Make sense to me. @nstjean @cesswairimu what do you guys think?

Yes I agree, they should be consistent and it doesn't need a password check.

@jywarren @emilyashley what do you think?

Hmm, yeah, that sounds okay to me.

I think email, location, and location privacy settings are things I would expect password validation for. Are either of those editable from the bio section? (Thanks, still learning how all the pieces interact :) )

Ok so this is ready to approve if we can verify that changing the account's email, changing the location, and changing the location privacy settings are behind password validation.

Checked on my account:

  • changing email address is behind the password.

@ebarry Thanks for the update! Oops my bad :sweat_smile: Maybe I can modify this pr to just allow changing the bio without password but require password for changing the email ...will have to look into this though :sweat_smile:

Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label :tada: . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! :100: Thank you for your contributions :raised_hands: :balloon:.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jywarren picture jywarren  路  154Comments

ebarry picture ebarry  路  73Comments

cesswairimu picture cesswairimu  路  79Comments

SidharthBansal picture SidharthBansal  路  142Comments

jywarren picture jywarren  路  98Comments