Plots2: change function t to translation in app/views/tag/show/_nav_tabs.html.erb

[Shulammite-Aso]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file _nav_tabs.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red which lines to remove, and in green which lines to add:

- <i class="fa fa-question-circle"></i> <span class="d-lg-inline"><%= t('tag.show.questions') %></span>
+ <i class="fa fa-question-circle"></i> <span class="d-lg-inline"><%= translation('tag.show.questions') %></span>

Do this for lines 10 13 14 17 24 26 32 37 40 43 and 46.

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

[SeriousHyena]

I would like to claim this issue please

[Shulammite-Aso]

It's yours @SeriousHyena 😄

[SeriousHyena]

Thanks I will let you know if I have any questions
Sent from Yahoo Mail on Android

On Sat, Mar 21, 2020 at 11:45 AM, [e-mail] wrote:

It's yours @SeriousHyena 😄

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Shulammite-Aso]

Thanks I will let you know if I have any questions Sent from Yahoo Mail on Android On Sat, Mar 21, 2020 at 11:45 AM, [e-mail] wrote: It's yours @SeriousHyena — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Cool.

[SeriousHyena]

I have just started working on it and will hopefully have it figured out shortly.

Thanks,
SeriousHyena

[SeriousHyena]

Hi Shulammmite-Aso:
I notice that most of the lines to edit do not have exact code " <%= translation('tag.show.questions') %>" In that case do I just add the revised code and leave the exisiting line or replace it with the proposed change.

Thanks,
SeriousHyena

[Shulammite-Aso]

@SeriousHyena you are to only change the t in those lines translation, every other code in the various lines should remain as they are.

[SeriousHyena]

Great thanks

[nicoleiocana]

@SeriousHyena Is there anything that I can do to offer support? I see that you were assigned this issue, but have yet to create a PR? Just wanted to offer my help, but I am sure that you got this!

[SeriousHyena]

Good afternoon I have received the responses regarding my PR and will respond today to the issues.
Thanks,
SeriousHyena

Sent from Yahoo Mail on Android

On Wed, Mar 25, 2020 at 11:16 AM, [e-mail] wrote:

@SeriousHyena Is there anything that I can do to offer support? I see that you were assigned this issue, but have yet to create a PR? Just wanted to offer my help, but I am sure that you got this!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[SeriousHyena]

Hi Nicole Yes thank you very much I do believe I have it I just need to get on the computer to get it sorted out and finished off Thank you very much it should be done today

[cschweipert]

@Shulammite-Aso Hi. I am an outreach applicant and would like to work in this or another issue. @SeriousHyena Did you make a pull request? Maybe I can help out if you are stuck.

[SeriousHyena]

Yes I'm taking a look at that right now I thought I made that successfully so but apparently not so let me take a look at that and I'll keep you posted.

Thank you,

Serious Hyena

[SeriousHyena]

Hi I am new to this so am trying to figure out the process still. I made the changes except screenshot as I'm not sure how to actually run the entire program . Please let me know if I need to provide more information.
Thanks,
Serious Hyena

Sent from Yahoo Mail on Android

On Fri, Mar 27, 2020 at 1:21 PM, [e-mail] wrote:

@Shulammite-Aso Hi. I am an outreach applicant and would like to work in this or another issue. @SeriousHyena Did you make a pull request? Maybe I can help out if you are stuck.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[nicoleiocana]

@SeriousHyena No worries. We have all been newbies before, so we totally understand. Let me help clear up some things:

1. On #7709, @pydevsg was asking you to change the title from Update lines 10 and 13 to change function t to translation on lines 10 and 13 in app/views/tag/show/_nav_tabs.html.erb (or something similar) so the title describes what the PR does exactly.
2. Inside your first post where you wrote Fixes #7709 (Update lines 10 and 13), @pydevsg wanted you to write the number of the issue that you are fixing, issue #7703. #7709 is the PR (Pull Request) that fixes issue #7703. You should change it to Fixes #7703 (Update lines 10 and 13).
3. Your PR will most likely not be approved because you changed more code than @Shulammite-Aso requested. When @Shulammite-Aso stated to _only change the t in those lines translation_, you were to find the code that looked like this:
   t(
   and replace it with this code:
   translation(
   Unfortunately, your code modified more than that and is now in jeopardy of breaking that portion of the site.

Lemme know if this helps or you need me to clarify what I wrote. Best of luck! You got this!

[nicoleiocana]

@cschweipert The PR is #7709. It was accidentally misnumbered, which is why we don't see the notification of the linked PR in this thread.

[nicoleiocana]

@cschweipert If you are still looking for a FTO issue, I put up a bunch this early afternoon.

[pydevsg]

Thanks for the clear cut explaination @nicoleiocana to @SeriousHyena in my behalf.

[nicoleiocana]

@pydevsg You are welcome, no problem.

[anshalshukla]

Can I claim this issue as there has been no activity in a while

[nicoleiocana]

@anshalshukla You got it!

[anshalshukla]

@nicoleiocana have linked PR #7881 to solve this issue and that has been reviewed by @govindgoel . I wonder want needs to be done next.

[nicoleiocana]

@anshalshukla Nothing, you are done. Awesome job! In a couple of days, your PR will be merged and then this issue will be closed. Congrats! 🎉

[jywarren]

Hi @Rohit-786, it looks like perhaps you opened a pull request for an issue that someone is already solving? If so, that's OK, i'm sure we can find you a new project to take on instead. Thank you!

[jywarren]

And thank you @nicoleiocana for being such a welcoming presence!

[nicoleiocana]

@jywarren Glad to be of help.

[Annysah]

@cesswairimu,
I'm Anisat Akinbani an Outreachy Applicant and I would love to work on this issue.

[jywarren]

Please go ahead! We'd love your help!!

On Thu, Oct 8, 2020, 7:57 AM Anisat Akinbani [e-mail]
wrote:

@cesswairimu https://github.com/cesswairimu,
I'm Anisat Akinbani an Outreachy Applicant and I would love to work on
this issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/7703#issuecomment-705520014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J2UF5Q5XXNX4QXROOTSJWSL3ANCNFSM4LQ5I6AQ
.

[anumi1999]

Hi, Are there any issues left for first-timers? I would also like to contribute

[jywarren]

I believe this one is completed, but you can ask for one in #9083, thank you!!!