Plots2: configurable email notification preferences

[jywarren]

We are having settings at /settings as we might wanna add more settings in future. Below are the settings which would be added to settings page:

Asking: Do you want to be notified by email for (with toggles):

• [x] comments on your posts
• [x] comments on all posts you've commented on
• [x] likes on your posts
• [x] notes on a topic (we have this already!)
• [ ] notifications for wiki page edits: https://github.com/publiclab/plots2/issues/396 (after all the rest!)
• [ ] The monthly blog would be everything tagged blog once per
  month? What user tag would that be? (by @jywarren )
• [x] Digest- weekly
• [x] Digest - daily

[ebarry]

This seems to relate to how the button "subscribe to everything" on publiclab.org/subscriptions in fact only subscribes you to research notes, a fact which we have to explain in help text below the button

[jywarren]

that's a great issue to break off as a stand-alone -- maybe good for
first-timers!

On Wed, Jan 24, 2018 at 5:40 PM, Liz Barry [e-mail] wrote:

This seems to relate to how the button "subscribe to everything" on
publiclab.org/subscriptions in fact only subscribes you to research
notes, a fact which we have to explain in help text below the button

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/213#issuecomment-360298489,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxWtH-GFkU6nnhL0qKM_Gkcwl913ks5tN7FZgaJpZM4DjowO
.

[grvsachdeva]

hi @jywarren @ebarry , I have included this issue as a part of my proposal https://publiclab.org/notes/gauravano/02-18-2018/gsoc-proposal-email-integration-project

What do you think about design ?

[jywarren]

Oh cool! I wonder about mobile display, but if it's an issue we can
probably put it in a regular page instead of a modal - either way is
awesome!

On Wed, Mar 21, 2018, 5:22 PM Gaurav Sachdeva [e-mail]
wrote:

hi @jywarren https://github.com/jywarren @ebarry
https://github.com/ebarry , I have included this issue as a part of my
proposal
https://publiclab.org/notes/gauravano/02-18-2018/gsoc-proposal-email-integration-project

[image: notification_screenshot]
https://user-images.githubusercontent.com/20878070/37738062-ca4947c6-2d7b-11e8-9ebc-9afe7d7c632a.png

[image: notification_settings]
https://user-images.githubusercontent.com/20878070/37738082-dc2aeea4-2d7b-11e8-936f-d6e9fe7f5cad.gif

What do you think about design ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/213#issuecomment-375099924,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5A6_axq64vGqTuFfVdtQNp_b3k5ks5tgsRhgaJpZM4DjowO
.

[grvsachdeva]

Sure @jywarren , we can put it in the page, right now there are only a few setting options so I thought modal would look nice.

[jywarren]

i do think it looks nice! Just thinking ahead in case it doesn't render
well on mobile. :-)

On Wed, Mar 21, 2018 at 7:04 PM, Gaurav Sachdeva [e-mail]
wrote:

Sure @jywarren https://github.com/jywarren , we can put it in the page,
right now there are only a few setting options so I thought modal would
look nice.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/213#issuecomment-375124505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ4KxqL0zb3mgqrfNcwZQsAF-5P6rks5tgtyGgaJpZM4DjowO
.

[grvsachdeva]

@jywarren , can you review my proposal https://publiclab.org/notes/gauravano/02-18-2018/gsoc-proposal-email-integration-project now if it's possible. Thanks.

[grvsachdeva]

hi @jywarren @ebarry , I have rendered the design on a separate page and also tested on mobile. Here's preview:-

Mobile view:-

[grvsachdeva]

hi @jywarren, I can include all the above-mentioned items of the checklist on the Settings page, could you please suggest relevant tag names for each. Thanks.

[jywarren]

This sounds great. Can you suggest a first draft list and I can provide some edits or suggestions?

[grvsachdeva]

Tag Names:

1. For direct comments on author's own post - comment_direct:true
2. For indirect comments i.e., on posts where the current user has commented - comment_indirect: true
3. Likes on your post - post_like:true

How about these @jywarren?

[jywarren]

we could also do notifications:comment-direct and
notifications:comment-direct and just have non-existence be "off" -- what
do you think? so each one would start with a common prefix of
notifications:_____?

On Wed, Jun 27, 2018 at 2:34 PM Gaurav Sachdeva [e-mail]
wrote:

Tag Names:

1. For direct comments on author's own post - comment_direct:true
2. For indirect comments i.e., on posts where the current user has
   commented - comment_indirect: true
3. Likes on your post - post_like:true

How about these @jywarren https://github.com/jywarren?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/213#issuecomment-400786007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ04F3-shi0p0wSyYdtksDxf7JZ1xks5uA9AigaJpZM4DjowO
.

[grvsachdeva]

Sounds good to me!

[grvsachdeva]

hi @jywarren in reference to our last conversation about tag approval, I have some idea about it. Normally, users change settings once a while, so instead of generating 5 to 6 tags for each profile, we can generate tag if a user doesn't want to receive notification related to a particular setting. What do you think?

[jywarren]

So we'd have a set of defaults that don't require a tag to be set, right -- that does make sense. So what would be the defaults? We'd want to document those clearly somewhere.

Good thinking! 👍

[grvsachdeva]

Yes, we should definitely document them as soon as we are done with the function - let's think of some names related to these tags only-
notifications:comment-direct like no-notifications:comment-direct or no-notify:comment-direct. What do you think @jywarren ?

[jywarren]

How about:

notify-comment-direct:false -- this goes back to your earlier way, but given the default "on", it makes sense. 👍

[grvsachdeva]

Great! I will complete PR shortly. Thanks!

[grvsachdeva]

Hi @jywarren the PR at #2985 is done with comment-indirect notification setting and settings page. I would handle other settings in a separate PR for modularity. I hope that's fine. Thanks!