Plots2: Displaying of go to top button

Created on 10 Feb 2020  路  14Comments  路  Source: publiclab/plots2

At the top of webstie the go to top button should not be displayed which is displaying in this case.

Screenshot from 2020-02-10 18-53-07

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

bug

Most helpful comment

Hey @cesswairimu, I can see that too. I'm looking to see what has gone wrong

All 14 comments

@VladimirMikulic @SidharthBansal please review this.

That would be a very nice UI improvement :+1:
@NitinBhasneria you are doing great work!

I see what is the problem. The file scroll-func.js is in the root folder.
You should move it to plots2/app/assets/javascripts.

After you do that, add an entry in plots2/app/assets/javascripts/application.js to make it compile with other scripts.
You could as well format the scroll-func.js properly.

Thank you.

yea, I got it thnx.

i will like to check this issue out and work on it, if possible because i see its still open

Hi @NitinBhasneria if this issue is still open, I'd love to work on it

Hey @tawahpeggy @fiona-byte!
This issue was already solved in #6944 (merged might not be in production yet) and then in #7466.
You can check out the linked PR for more context. Maybe you can help finding the errors in that PR to get that merged.

All the best!

Thanks a lot @shreyaa-sharmaa

@fiona-byte you can check on https://stable.publiclab.org/ I am checking too

Looks like its still displaying, @shreyaa-sharmaa @fiona-byte could you please confirm..stable has all the changes on main

Hey @cesswairimu I can see that too.

@NitinBhasneria 's PR for the same mentions that it wasn't visible at all then? Strange. :thinking:

Yeah that's strange. @NitinBhasneria any ideas what could have gone wrong?

Hey @cesswairimu, I can see that too. I'm looking to see what has gone wrong

Any updates @fiona-byte?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

keshavsethi picture keshavsethi  路  3Comments

bronwen9 picture bronwen9  路  3Comments

ebarry picture ebarry  路  3Comments

noi5e picture noi5e  路  3Comments

divyabaid16 picture divyabaid16  路  3Comments