Plots2: Refresh page upon adding location tags

Created on 27 Jan 2020  路  9Comments  路  Source: publiclab/plots2

I heard from someone who was confused as to why the map didn't appear upon adding location tags, so I think we should initiate a page refresh when that happens -- what do you think, @nstjean @crisner -- does this makes sense? We could just do this in JS after hearing a success for the tag POST?

Thanks! Just a thought that this might be a better user experience!

JavaScript feature fto-candidate help wanted

All 9 comments

Yes I agree! I think it should refresh after adding any power tag, because things like place:xx will change the view of the page as well.

ah, good thought! can you point to the code where we submit these? I think you did a lot of great work to consolidate this code and perhaps it's a one-line change!

I heard from someone who was confused as to why the map didn't appear upon adding location tags, so I think we should initiate a page refresh when that happens

Sounds good to me.

This is the function that is called when tags are successfully added:
https://github.com/publiclab/plots2/blob/f6e37826002aef04843a6f448c3dedef5ae2e35b/app/assets/javascripts/tagging.js#L71-L89

I believe tag[0] is the tag name.
We can check for specific power tag names: if (!!tag[0].split(':')[0].match(/^(lat|lon|place)$/)) { }

@jywarren I would like to work on this issue. May I ?

@NitinBhasneria Go ahead! If you need help just let me know.

ok, I will be working on this.
thanks @nstjean

by adding the location.reload(true); in the code given by you @nstjean it will work fine.
What do you think?

Yes, that sounds good!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

keshavsethi picture keshavsethi  路  3Comments

keshavsethi picture keshavsethi  路  3Comments

grvsachdeva picture grvsachdeva  路  3Comments

RuthNjeri picture RuthNjeri  路  3Comments

first-timers[bot] picture first-timers[bot]  路  3Comments