Plots2: Remove redundant text written twice: MADE: time
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
- goto https://publiclab.org
- Head over to blog section
[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update
FILE: _notes.html.erb
CHANGES YOU HAVE TO MAKE:
Remove this line: along with "li" tag
See this page for some help in taking your first steps!
[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
- [ ] 🏁 Done Ask in comments for a review :)
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
gptshubham595
All 21 comments
@gptshubham595 should i take this
123abhay
on 5 Nov 2019
@123abhay go for it
gptshubham595
on 5 Nov 2019
@123abhay are you working nr this issue else @gptshubham595 can I work on this?
swathi-0901
on 7 Nov 2019
@swathi-0901 wait for one more day then you can proceed
gptshubham595
on 7 Nov 2019
@gptshubham595 can u please tell in detail what is to be done.
thank you
swathi-0901
on 9 Nov 2019
@swathi-0901 sure
gptshubham595
on 9 Nov 2019
You can see this PR once help
https://github.com/publiclab/plots2/pull/6746
You have to make changes in this file _notes.html.erb
Happy contributing!!
gptshubham595
on 9 Nov 2019
@swathi-0901 I think you are working on a fto issue. One person can take atmost one fto issue. So, you can take other non first timer issues.
First timer issues are only for new contributors. I think you will be happy to take other issues and let new contributors come in at PL
Thanks for understanding Swathi
SidharthBansal
on 9 Nov 2019
@gptshubham595 you are requested to add codelinks in the issue body
SidharthBansal
on 9 Nov 2019
sure @SidharthBansal Thanks for updating
,Done!
gptshubham595
on 9 Nov 2019
@keshav234156 @jywarren Hey I have already made two PRs for an FTO, can I claim this issue? Also, I am not clear on what is to be done in this task. I assume, we have to make this an FTO task and in order to do that, figure out the lines to be deleted from the code.
Srija616
on 13 Mar 2020
Hi, I am Jigyasa, and I am an Outreachy 2020 applicant. Is this issue open, and can I work on this?
Jigyasa-Kumari
on 17 Mar 2020
Hello, is anyone working on this issue? If no, can I do it?
swarajpure
on 8 Jun 2020
@cesswairimu, thank you! You can assign this to me, I'd like to work on it.
RuthNjeri
on 8 Oct 2020
Great, done
cesswairimu
on 8 Oct 2020
@cesswairimu I don't think this issue is still valid, the notes partial has been refactored since this issue was created. When I create a test note, there is no redundancy with the Made: section.
The main branch shows that the line of code suggested in this issue is currently in the card partial and no longer in the file suggested here.
RuthNjeri
on 8 Oct 2020
Oh yeah you are right. You can edit on that file. Thanks
cesswairimu
on 8 Oct 2020
@cesswairimu Is that line of code still redundant? I guess I can’t pinpoint how it is
redundant
On Thu, Oct 8, 2020 at 11:24 PM Cess notifications@github.com wrote:
Oh yeah you are right. You can edit on that file. Thanks
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6685#issuecomment-705803233,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2FBWYRIZRF4UZE3CKXXWDSJYNWJANCNFSM4JJFVYXA
.
RuthNjeri
on 8 Oct 2020
I think the person was saying it was just telling the "time ago" twice. So, maybe we can remove the "Made:" version? Thanks!
jywarren
on 8 Oct 2020
Its showing the time on view mode, and also on clicking the three dots like so
cesswairimu
on 8 Oct 2020
That makes sense, thanks @jywarren and @cesswairimu. I'll remove the "Made"
RuthNjeri
on 9 Oct 2020
Related issues
keshavsethi
·
3Comments
ebarry
·
3Comments
![first-timers[bot] picture](https://avatars.githubusercontent.com/in/4832?v=4&s=40)
first-timers[bot]
·
3Comments
RuthNjeri
·
3Comments
milaaraujo
·
3Comments