Plots2: multiple page tab bars

[steviepubliclab]

I was on this page https://publiclab.org/questions/tag/pm?page=2 scrolling through questions, when I saw it has two scroll bar arrows to toggle between pages:

[nstjean]

I'll take this on. :)

[CoderJolly]

I'll take this on. :)

Sure @nstjean , pls go ahead. Feel free to ask anything. 😄 😄

[nstjean]

So I've identified the problem - the asked-tab and answered-tab are both showing at all times even though only one is marked active. I can easily update the CSS to hide the inactive one, but there are further problems:

1. The tabs at the top of the page don't work to switch the active group.
2. There are no questions in the "answered" section, only in the "asked" section
3. The paginator for the "answered" section is displaying for the number of items in "asked" - this may be fixed when the logic for #2 is fixed.

My question is, do I solve just the initial problem with a pull request and break up the remainder into new issues? Or should I fix all of it together?

[grvsachdeva]

If you have a good understanding of related code then go ahead for solving all parts, as you need to increase complexity bit by bit. Thank you!

[nstjean]

Ok, I'll go ahead and try it! I am new to Ruby but this will be a good challenge.

[grvsachdeva]

Oh, I hope, it's not your first issue, because you might wanna try an easier issue first.

[nstjean]

Ok what I'll do is split it up. I'll solve the first part of this, the easy issue, and do a pull request for practice. Then I'll look into what needs to be done for getting the tabs working as a separate issue. :)

[grvsachdeva]

Sounds great!

On Sat, Oct 5, 2019 at 9:45 PM Natalie St Jean [e-mail]
wrote:

Ok what I'll do is split it up. I'll solve the first part of this, the
easy issue, and do a pull request for practice. Then I'll look into what
needs to be done for getting the tabs working as a separate issue. :)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6387?email_source=notifications&email_token=AE7JF5VLBM7MPKZ5UMRR6WTQNC4RNA5CNFSM4I5EAYNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANVYKY#issuecomment-538663979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE7JF5UEYRZLP4N2HJQWJD3QNC4RNANCNFSM4I5EAYNA
.

[CoderJolly]

So I've identified the problem - the asked-tab and answered-tab are both showing at all times even though only one is marked active. I can easily update the CSS to hide the inactive one, but there are further problems:

1. The tabs at the top of the page don't work to switch the active group.
2. There are no questions in the "answered" section, only in the "asked" section
3. The paginator for the "answered" section is displaying for the number of items in "asked" - this may be fixed when the logic for #2 is fixed.

My question is, do I solve just the initial problem with a pull request and break up the remainder into new issues? Or should I fix all of it together?

Sorry, for replying late but I think @gauravano cleared your doubt.

You can create a PR for the initial problem and the make an issue regarding the remaining !! 😄 😸

[jywarren]

Fixed in #8689 ! Thank you!!!!