Plots2: Correct Sign-up Form Validation message

[SidharthBansal]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Problem

When a user tries to submit an empty sign up form, and also does not check off the recaptcha box, This output is shown:

Solution

Instead, we want all the relevant errors ("field cannot be empty" or so) to be listed along with the failed recaptcha verification.

Each box in this problem is worth some points. We will accept answers that complete one part and not the other, but encourage you to go for all 3. Completion of all three will result in bonus points :)

• [ ] fix the create action so that the correct errors show
• [ ] fix the error messages themselves as well. If you see below, there are three different errors for email, but only one of them is correct.
• [ ] write a test reflecting this fix. Guidelines: the test must fail without your changes, and your changes are what makes it pass.

[SidharthBansal]

Codelinks

1. Sign Up form - https://github.com/publiclab/plots2/blob/master/app/views/users/_create_form.html.erb
2. Dynamic form - https://github.com/publiclab/plots2/blob/5c0d96274bd0be15feba69d8f30093082402ace5/lib/dynamic_form/action_view/helpers/dynamic_form.rb
3. Local files - https://github.com/publiclab/plots2/blob/3a96771279cf4fbf31ff6279f99f068a6d7a2a47/config/locales/en.yml

[ananyaarun]

This has been uploaded to GCI dashboard, Thanks !

[SidharthBansal]

From #3340

[chen-robert]

Can I have this task assigned to me?

[SidharthBansal]

Are you notdeghost?

On Fri, 6 Dec 2019, 3:28 am Robert Chen, [e-mail] wrote:

Can I have this task assigned to me?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6303?email_source=notifications&email_token=AFAAEQYXKXESWGK655K5KL3QXF2RPA5CNFSM4IXESK2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCJL4Y#issuecomment-562337267,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ3ZVB4QWIYMKDRHSMDQXF2RPANCNFSM4IXESK2A
.

[chen-robert]

Yes

[SidharthBansal]

Go ahead

On Fri, 6 Dec 2019, 12:28 pm Robert Chen, [e-mail] wrote:

Yes

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6303?email_source=notifications&email_token=AFAAEQYFXJVUIDNZIXWMS4TQXHZYNA5CNFSM4IXESK2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGDGVII#issuecomment-562457249,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQZLGCJUNC5WU7FYBBLQXHZYNANCNFSM4IXESK2A
.

[chen-robert]

Great, thanks!

[chen-robert]

@SidharthBansal I've fixed the first two parts but I'm not too sure how to write the tests. Should it be under system, unit, integration, or something else? I would greatly appreciate it if you could point me in the right direction, thanks!

[SidharthBansal]

What do you think?
It depends on your thinking.
If you are testing a sequence as follows:

1. Sign up with wrong details
2. Sign up with right details
3. Dashboard with welcoming message
   1-3 suggests integration test altogether
   If you want to just test 1 then unit test will work.
   Functional tests are for controllers.

[SidharthBansal]

Please think the intended behavior and write test(s) accordingly

[SidharthBansal]

What is the PR numberl?

[chen-robert]

@SidharthBansal I have not made the PR yet, I wanted to write the test before proceeding.

[SidharthBansal]

ok

On Fri, Dec 6, 2019 at 11:29 PM Robert Chen [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal I have not made the
PR yet, I wanted to write the test before proceeding.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6303?email_source=notifications&email_token=AFAAEQYPBU4NCMI7AKFH443QXKHH7A5CNFSM4IXESK2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGE4ASA#issuecomment-562675784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ47U6BQMHQNV4XTCWTQXKHH7ANCNFSM4IXESK2A
.

[SidharthBansal]

Please tell me the code link so that I can make it hard instead of medium

[SidharthBansal]

Changed to hard from medium

[SidharthBansal]

As this issue may require multiple tests, I will be happy to open a hard task for tests for this issue. Chen can claim and get points for both the hard tasks once his pr is merged.
Thanks

[SidharthBansal]

@chen-robert I observed that you have not claimed this task on the dashboard. Why?

[chen-robert]

@SidharthBansal the task expired for me on the GCI dashboard. Is there any way for me to reclaim it or extend the time limit?

[chen-robert]

I had initially claimed it and was working on it but it expired when I was sleeping. I was unable to find it afterward and wasn't sure if you had removed it?

[chen-robert]

Also, all three of my other PRs are ready to merge now, I've fixed the corresponding Travis errors :tada:

[SidharthBansal]

Please try to reclaim it.

[SidharthBansal]

I have not removed it

On Sat, Dec 14, 2019 at 11:44 AM Robert Chen [e-mail]
wrote:

Also, all three of my other PRs are ready to merge now, I've fixed the
corresponding Travis errors 🎉

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6303?email_source=notifications&email_token=AFAAEQ3NKLJUAFNBTLIFFEDQYR2UFA5CNFSM4IXESK2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG33NNI#issuecomment-565687989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ5KJ7CFFZLDLEIRYBTQYR2UFANCNFSM4IXESK2A
.

[chen-robert]

@SidharthBansal I have reclaimed it now, thanks!

[SidharthBansal]

This issue is resolved

[SidharthBansal]

@chen-robert kindly reclaim it on dashboard for points