Plots2: Create new question page (following style guide!)

[jywarren]

1994 describes the new design style guide, and we now have new designs for the basic Note and Wiki pages. But the Questions page is still looking a bit old. We should make the questions page use the same template as the notes page, so it is similarly cleaned up. We may need to preserve the "related questions" on the sidebar. But otherwise let's get it looking nice and minimal again!

We'd love help with this!

[digitaldina]

@jywarren @CleverFool77 sorry for my absense the past few months! It was a busy time with family, friends, work and school so I took some time off of github. I'll be a lot more active the coming months so you'll see me around more often :) This looks like a good issue for me to start on. I think @CleverFool77 tried to update the design for the questions page in #5948 but her changes weren't applied. Should I open a new PR and add your changes to app/views/questions/__questions.html.erb ?

[jywarren]

Please Note: We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more

Problem

Here, we're trying to work on the full question page itself - like at this URL:

https://publiclab.org/questions/adam-griffith/08-27-2019/favorite-camera-for-balloon-kite-mapping

See how it differs (not a huge amount, but in some key ways) from the basic notes page:

https://publiclab.org/notes/warren/08-27-2019/bringing-public-lab-s-multispectral-image-processing-to-leaflet-maps

The changes are pretty small, actually, just the header, really:

[jywarren]

Also noting that there is a "tidying up the header" issue open here which applies equally to Wikis, Notes, and Questions:

https://github.com/publiclab/plots2/issues/5956

That'd be a great follow-up to this one!

[pydevsg]

@jywarren , I think we can add this issue for GCI task list, with medium tag.

[jywarren]

Awesome! I can tag it if you want to add it? Thanks!

On Mon, Sep 30, 2019 at 4:06 PM Sudipto Ghosh [e-mail]
wrote:

@jywarren https://github.com/jywarren , I think we can add this issue
for GCI task list, with medium tag.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6294?email_source=notifications&email_token=AAAF6J4UWMHXOHSHP7ERUELQMJLY7A5CNFSM4IWXS6R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD765KYY#issuecomment-536728931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J62KVCRC3LGVZ4FOOTQMJLY7ANCNFSM4IWXS6RQ
.

[pydevsg]

Yes, do add a gci and medium tag @jywarren , this will be a great task.

[digitaldina]

i'll be finishing this up this weekend. Setting up my local dev environment took longer than expected :/

[pydevsg]

@dinaelhanan , this task is assigned for the gci candidates.So, if you haven't done any PRs its fine , please don't make one. Thanks :)

[pydevsg]

Updated on GCI Dashboard

[SidharthBansal]

Published

[Uzay-G]

Hey @jywarren I was trying to look at how I could change the design and noticed that the question page sidebar is not placing itself next to the body of the question but instead it is placed after all the comments at the bottom of the page.

I don't have this problem on my local server so I used my devtools and noticed that this div of the application.html.erb file is somehow not a parent of the sidebar. https://github.com/publiclab/plots2/blob/3bd5522fbedfebdd24fb6062e59ee587df3f2324/app/views/layouts/application.html.erb#L117
I'm not sure if this is an actual problem because the stable version of publiclab and my local server work fine so it's just the publiclab.org website.

A potential cause for this would be that an </div> tag was added somewhere that is closing the <div class="row"> too early.

[jywarren]

Oof, those are the toughest type of HTML error to find. Can you confirm this is happening on all question pages, or is it possibly related to just that one page? Thanks!

[Uzay-G]

The error (at least for me) is present on about half of the questions of the publiclab site I am looking at and is not present at all locally. Example problem pages are:

• https://publiclab.org/questions/stevie/12-04-2019/what-are-the-health-impacts-of-the-aluf-plastics-plant-from-air-pollution
• https://publiclab.org/questions/stevie/12-16-2019/are-there-simple-tests-for-nitrates-in-well-water
  -https://publiclab.org/questions/francesco49/11-22-2019/driver-usb-camera-community-microscope
• https://publiclab.org/notes/warren/08-27-2019/bringing-public-lab-s-multispectral-image-processing-to-leaflet-maps
  This one seems fine: https://publiclab.org/questions/ThomasTaufan/11-26-2019/how-can-i-process-the-images-taken-from-modified-camera

[Uzay-G]

Should I create an issue?