Plots2: Popular tags

[Gagan6730]

When we click "more" to see more popular tags, the "more" button stays as it is. It should change to "less" and probably appear at the end of all the popular tags.

See: https://publiclab.org/tags#

[lokcito]

I've tried to review that in repository but that content is recorded in database and is shown by helper: 'feature'. Or how can we modify this, where is that content located in code of project?

any idea to solve that?

[Gagan6730]

I've tried to review that in repository but that content is recorded in database and is shown by helper: 'feature'. Or how can we modify this, where is that content located in code of project?

any idea to solve that?

Can you state the file in which you found this? @lokcito
Thanks

[jywarren]

This is mentioned in the doc/DATA_MODEL.md file, good find! It is based on
static HTML, so if you view the source of the page on the live site, you
can see it. I might recommend that we simply hide the "more" link instead
of change it, which could be less code. I think it might be like
$(this).hide() do to so?

If you want to submit new code for this, please send a GIF of it working
and include the code in a Gist, linked in a comment here. Then we would
love to update the live site with your code. Thank you!

On Fri, Aug 30, 2019 at 1:55 AM Gagandeep Singh [e-mail]
wrote:

I've tried to review that in repository but that content is recorded in
database and is shown by helper: 'feature'. Or how can we modify this,
where is that content located in code of project?

[image: code]
https://camo.githubusercontent.com/0008cbfd64a007258b06ffda4da912d28e33869c/68747470733a2f2f692e696d6775722e636f6d2f63647a58324d5a2e706e67

any idea to solve that?

Can you state the file in which you found this? @lokcito
https://github.com/lokcito
Thanks

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6222?email_source=notifications&email_token=AAAF6J2JXZLOEY5HFWAW3C3QHCY4VA5CNFSM4ISGNTU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QUGFQ#issuecomment-526467862,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J3WKIYBSSR75WOR6YLQHCY4VANCNFSM4ISGNTUQ
.

[seabl]

@Gagan6730 see file app/helpers/application_helper.rb, starting line 47

[Gagan6730]

This is mentioned in the doc/DATA_MODEL.md file, good find! It is based on static HTML, so if you view the source of the page on the live site, you can see it. I might recommend that we simply hide the "more" link instead of change it, which could be less code. I think it might be like $(this).hide() do to so? If you want to submit new code for this, please send a GIF of it working and include the code in a Gist, linked in a comment here. Then we would love to update the live site with your code. Thank you!
…

Hey @jywarren
I am a bit confused. I read about features and know that they are static HTML and could be used as they are. So, can we edit any feature through the code base or it is just something admin could do through the site??
Thanks

[jywarren]

Indeed, admins do this through the site. I'm an admin, so if you share some
code that you know works, i can add it as a Feature on the live site!

On Sat, Aug 31, 2019 at 10:56 AM Gagandeep Singh [e-mail]
wrote:

This is mentioned in the doc/DATA_MODEL.md file, good find! It is based on
static HTML, so if you view the source of the page on the live site, you
can see it. I might recommend that we simply hide the "more" link instead
of change it, which could be less code. I think it might be like
$(this).hide() do to so? If you want to submit new code for this, please
send a GIF of it working and include the code in a Gist, linked in a
comment here. Then we would love to update the live site with your code.
Thank you!
… <#m_2531971893715487552_>

Hey @jywarren https://github.com/jywarren
I am a bit confused. I read about features and know that they are static
HTML and could be used as they are. So, can we edit any feature through the
code base or it is just something admin could do through the site??
Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6222?email_source=notifications&email_token=AAAF6JZWGOLPL4GJZ2PZ7UDQHKBANA5CNFSM4ISGNTU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TOJQI#issuecomment-526836929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J4IG7ZMO55MECIVSUTQHKBANANCNFSM4ISGNTUQ
.

[Gagan6730]

Hi @jywarren
cc @gauravano
I have attached a gif of working code below. Could you please have a look.
Link to gist: https://gist.github.com/Gagan6730/9727d5c3fc65c081ad5b7a681f82f241

[Gagan6730]

@jywarren I was hoping you could review the changes.
Thanks

[jywarren]

So sorry for the delay! This is perfect. I've updated https://publiclab.org/tags as well. Thanks a ton!