Plots2: Expanded "be friendly to newcomers" message in comment forms

[jywarren]

Stack Overflow has this nice message we could adapt from in our own comment form!

Would anyone like to give this a try?

Changes to be made: https://github.com/publiclab/plots2/blob/master/app/views/notes/_comments.html.erb#L18

Check if a user is a new contributor using user.is_new_contributor method, and show comment placeholder accordingly.

---

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

[Avantikaa]

Has someone started working on this? If no I am happy to start

[grvsachdeva]

Hi @Avantikaa, you can work on this one. Thank you!!

[seabl]

@jywarren What do you think should be the criteria for deciding if someone's a new contributor?

[jywarren]

That's a great question for @ebarry! We currently have a
"user.is_new_contributor?" method for users, here:

https://github.com/publiclab/plots2/blob/d4d69ab4144d1457749ff215c53b63e167cc7142/app/models/user.rb#L69-L75

That defines a newcomer as having only one node authored, and having it
been authored less than one month ago (that is, the create_at date should
be GREATER or 'later on' than the date 1 month ago):

Node.where(uid: id).length === 1 && Node.where(uid: id).first.created_at > 1
.month.ago

On Wed, Aug 28, 2019 at 3:33 PM Sea [e-mail] wrote:

@jywarren https://github.com/jywarren What do you think should be the
criteria for deciding if someone's a new contributor?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6096?email_source=notifications&email_token=AAAF6J3Y5MGKL7LWFUGWLZ3QG3HG3A5CNFSM4II4MUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MHFNY#issuecomment-525890231,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J6PL7J2GB2BXC3XASTQG3HG3ANCNFSM4II4MUNQ
.

[ebarry]

I think it is quite fair to define a new contributor as "having only one node authored, and having it
been authored less than one month ago"

We might consider extended the timeline as well. I believe currently, if someone has only ever posted once, our site marks them as "new contributor" indefinitely! Does anyone know if this is true?

[jywarren]

No, actually that's the 1-month part -- it's only for 1 month following
their post, so that should be OK.

What i think could be useful is to define a few milestones and build out
different "states" for each. But for the purposes of this issue, we can
just use this user.is_new_contributor? function to toggle the message.
Let's open another if we want to do an issue about "brainstorming different
newcomer milestones"? Thanks!

On Wed, Aug 28, 2019 at 5:10 PM Liz Barry [e-mail] wrote:

I think it is quite fair to define a new contributor as "having only one
node authored, and having it
been authored less than one month ago"

We might consider extended the timeline as well. I believe currently, if
someone has only ever posted once, our site marks them as "new contributor"
indefinitely! Does anyone know if this is true?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6096?email_source=notifications&email_token=AAAF6J35W6Q7LN4RSAEUKGTQG3SUBA5CNFSM4II4MUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPNNA#issuecomment-525924020,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J256NNFKBGVKDNZJ7TQG3SUBANCNFSM4II4MUNQ
.

[ebarry]

sound good!

[phone] / @lizbarry http://twitter.com/lizbarry / lizbarry.net

On Wed, Aug 28, 2019 at 5:20 PM Jeffrey Warren [e-mail]
wrote:

No, actually that's the 1-month part -- it's only for 1 month following
their post, so that should be OK.

What i think could be useful is to define a few milestones and build out
different "states" for each. But for the purposes of this issue, we can
just use this user.is_new_contributor? function to toggle the message.
Let's open another if we want to do an issue about "brainstorming different
newcomer milestones"? Thanks!

On Wed, Aug 28, 2019 at 5:10 PM Liz Barry [e-mail]
wrote:

I think it is quite fair to define a new contributor as "having only one
node authored, and having it
been authored less than one month ago"

We might consider extended the timeline as well. I believe currently, if
someone has only ever posted once, our site marks them as "new
contributor"
indefinitely! Does anyone know if this is true?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/publiclab/plots2/issues/6096?email_source=notifications&email_token=AAAF6J35W6Q7LN4RSAEUKGTQG3SUBA5CNFSM4II4MUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPNNA#issuecomment-525924020
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAF6J256NNFKBGVKDNZJ7TQG3SUBANCNFSM4II4MUNQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6096?email_source=notifications&email_token=AABHNHZXVA2LZ64HPVLABSLQG3TYXA5CNFSM4II4MUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MQFLI#issuecomment-525927085,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABHNH4BMQPN5WPKCJG4ZNTQG3TYXANCNFSM4II4MUNQ
.

[seabl]

@jywarren As this is a first-timers-only issue, maybe it'll help to include a hint at where in the comment form the change should occur.

[grvsachdeva]

Hey @seabl, this is a fto-candidate issue, where we give user a bit of hint to code solution. So, for this one, here's the line which need to be changed - https://github.com/publiclab/plots2/blob/master/app/views/notes/_comments.html.erb#L18

Thanks!

[grvsachdeva]

@jywarren should we modify the comment placeholder body or what if a user visits a new contributor's post? Or, anything else?

[jywarren]

Oh sorry, I don't quite understand -- can you explain a bit?

On Sat, Aug 31, 2019 at 3:09 PM Gaurav Sachdeva [e-mail]
wrote:

@jywarren https://github.com/jywarren should we modify the comment
placeholder body or what if a user visits a new contributor's post? Or,
anything else?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6096?email_source=notifications&email_token=AAAF6J3WJ52Q7BVLET6JY5TQHK6T5A5CNFSM4II4MUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TTNHY#issuecomment-526857887,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J52CV62EYLQEGDEEW3QHK6T5ANCNFSM4II4MUNQ
.

[stefanosu]

Hello, @gauravano is this issue still available?

[seabl]

@stefanosu yes it is. Please feel free to claim it. Thanks.

[stefanosu]

So if I understand this correctly we want to be able to use the user.is_new_contributor method to toggle to display the message? @seabl @jywarren

[seabl]

@stefanosu Yes, exactly!

[jywarren]

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

[Tlazypanda]

@jywarren Is this issue still available?

[jywarren]

Yes, i believe so!

On Mon, Dec 23, 2019 at 6:14 AM Sneha Mishra [e-mail]
wrote:

@jywarren https://github.com/jywarren Is this issue still available?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6096?email_source=notifications&email_token=AAAF6JYRULYOZKYXUYTJBHTQ2CMPNA5CNFSM4II4MUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHQ4Y5I#issuecomment-568446069,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6JY5YRYUPPHWFZHWK2TQ2CMPNANCNFSM4II4MUNQ
.

[Tlazypanda]

@jywarren I would like to work on this if it's alright :) Thanks :v:

[seabl]

@Tlazypanda please go ahead