Plots2: Fix the new question form

[CleverFool77]

Description

The UI is distorted due to bootstrap4 upgrade.
maybe we can work on this.
For eg -

• The toolbox regression.
• The field for tags look different from other fields.
• The flash notice width maybe ?

[jywarren]

Yes, let's make this as smooth and simple as possible!

Some of these changes we can also port back to the main /post form which
especially looks bad in mobile devices. Thanks!

On Wed, Jun 5, 2019, 10:29 AM Lekhika Dugtal [e-mail]
wrote:

Description

The UI is distorted due to bootstrap4 upgrade.
maybe we can work on this.
For eg -

• The toolbox regression.
• The field for tags look different from other fields.
• The flash notice width maybe ?

[image: gg]
https://user-images.githubusercontent.com/26685258/58964309-4c9dd100-87cc-11e9-916a-3dae7e9f26b9.gif

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5839?email_source=notifications&email_token=AAAF6J45QJMRPCNRMKQWKZLPY7ETRA5CNFSM4HTZQGRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXZEAMQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J2CMVPLVTTAMKNKXVDPY7ETRANCNFSM4HTZQGRA
.

[CleverFool77]

Hi @jywarren I went through the code for question-form. I seem to see a class called ple-guide but cant see the usage. I guess its the info which we were showing earlier on first column of grid ? But it's not used anymore. So should I remove it while fixing the form ?

[jywarren]

Yes, I think so, more used in the regular post form.

On Thu, Jun 6, 2019, 6:15 AM Lekhika Dugtal [e-mail]
wrote:

Hi @jywarren https://github.com/jywarren I went through the code for
question-form. I seem to see a class called ple-guide but cant see the
usage. I guess its the info which we were showing earlier on first column
of grid ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5839?email_source=notifications&email_token=AAAF6J2WGK53J7F5ISR7RCDPZEEWBA5CNFSM4HTZQGRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCZOMQ#issuecomment-499488562,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J4VZZ5ATDG2OZXNW2LPZEEWBANCNFSM4HTZQGRA
.

[CleverFool77]

So Should I remove it from question form as it doesn't have any usage here ?

[jywarren]

I think so. I thought perhaps it was necessary for some reason but if it
works fine without then all good!

On Thu, Jun 6, 2019, 7:29 AM Lekhika Dugtal [e-mail]
wrote:

So Should I remove it from question form as it doesn't have any usage here
?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5839?email_source=notifications&email_token=AAAF6J2LDRNNE6UABUAGAELPZENJ5A5CNFSM4HTZQGRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXDAXSI#issuecomment-499518409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J5K6CLQGJD5HZUMZU3PZENJ5ANCNFSM4HTZQGRA
.

[CleverFool77]

Hi @jywarren I went through code, Fixed some widths and other and came with results. The first column of grid which is class of ple-guide is empty. I guess it's because same code is used for other forms like /post. But in other forms there is info being showed in this first column where as its empty in questions form.
You can see the gap in the screenshot below.

So I guess that this class is not necessary in this questions-form. Although it is necessary in other forms but as we different files for both forms and they have different fields. So it wont have effect on others. maybe the work can be done on complete rearrangement of grid section for question-section. What do you say ?

[jywarren]

If it doesn't break the question form then that's fine to remove. Let's
keep it simple!

On Thu, Jun 6, 2019, 10:47 AM Lekhika Dugtal [e-mail]
wrote:

Hi @jywarren https://github.com/jywarren I went through code, Fixed
some widths and other and came with results. The first column of grid which
is class of ple-guide is empty. I guess it's because same code is used
for other forms like /post. But in other forms there is info being showed
in this first column where as its empty in questions form.
You can see the gap in the screenshot below.
[image: Screenshot from 2019-06-06 23-11-09]
https://user-images.githubusercontent.com/26685258/59054052-7b8d7300-88b0-11e9-9239-32863a6e369c.png

So I guess that this class is not necessary in this questions-form.
Although it is necessary in other forms but as we different files for both
forms and they have different fields. So it wont have effect on others.
maybe the work can be done on complete rearrangement of grid section for
question-section. What do you say ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5839?email_source=notifications&email_token=AAAF6J3BUSCL5FCCAFJYHVLPZFERJA5CNFSM4HTZQGRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXDUFSQ#issuecomment-499598026,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J7EDSJQDC3CM4KK4H3PZFERJANCNFSM4HTZQGRA
.