Plots2: Liking/emoji response updates for Bootstrap 4

[jywarren]

Just noting that in Bootstrap 4, the emoji response systems need a little styling help!

https://stable.publiclab.org/notes/warren/03-04-2019/testing-post#c17743

[scw248]

Hi @jywarren, could I give this one a try?

[scw248]

@jywarren actually, as I've played around with this, I realized this is a bit beyond me. Thanks for posting, and best of luck!

[jywarren]

OK, thanks in any case! We'd be happy to have another contribution from
you, and if you'd like we can help you find one?

On Thu, May 2, 2019 at 8:07 PM Stephen-Wright [e-mail]
wrote:

@jywarren https://github.com/jywarren actually, as I've played around
with this, I realized this is a bit beyond me. Thanks for posting, and best
of luck!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5647#issuecomment-488874701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J2U5NFNEPXYZCDAA53PTN6YRANCNFSM4HJZKP7A
.

[digitaldina]

I'd be happy to take this one :) Anywhere I should look to get started? @jywarren

[jywarren]

Awesome!!!!!!! Hi!!!!!

On Thu, May 9, 2019, 1:05 PM d1g1t4ld1n4 [e-mail] wrote:

I'd be happy to take this one :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5647#issuecomment-490986704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J56MIY36MUP3IJHB6TPURKU7ANCNFSM4HJZKP7A
.

[digitaldina]

@jywarren hi! where would I find the code for this? thanks!

[jywarren]

I believe here:
https://github.com/publiclab/plots2/blob/master/app/views/notes/_comment.html.erb

It looks a bit complex! Perhaps @viditchitkara can help on this too?

On Thu, May 9, 2019 at 3:06 PM d1g1t4ld1n4 [e-mail] wrote:

@jywarren https://github.com/jywarren hi! where would I find the code
for this? thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5647#issuecomment-491027987,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J6PVY4KLVBKOX6S6NDPURYYVANCNFSM4HJZKP7A
.

[digitaldina]

@jywarren @ViditChitkara that would be awesome!

[ViditChitkara]

I think the container of 'emojis' is at this line here. I think the positioning of this div has to made relative to its parent div. Then you may want to set top and bottom property of this div accordingly.
Here is a good article about positioning, you may want to have a look at. @dinaelhanan

[digitaldina]

@ViditChitkara I've made an attempt in the above PR, please check it out when you've got the time. Thanks!

[grvsachdeva]

Hi @dinaelhanan, I just saw this issue and realized that I have attempted this issue at https://github.com/Souravirus/plots2/pull/1 and it was merged in big bootstrap PR too, but I guess somehow my changes were overwritten, so I have opened a new PR at https://github.com/publiclab/plots2/pull/5736 solving this. As you can see in the image at #5736, there is still scope for improvement in it like hovering over emoji is not scaling the emoji like it used to and the distance between the + button and emoji menu shouldn't be there. So, you can work on this. Sorry, I wasn't able to check earlier. Thanks!